Meta Issue.
#2205673: [META] Remove all @deprecated functions marked "remove before 8.0"

CommentFileSizeAuthor
#8 2341461-8.patch938 bytesquietone
#6 drupal8-remove-form_options_flatten-2341461-6.patch1.01 KBesod
#4 drupal8-remove-form_options_flatten-2341461-2.patch939 bytesashutoshsngh
#1 drupal8-remove-form_options_flatten-2341461-1.patch671 bytesashutoshsngh

Comments

ashutoshsngh’s picture

ashutoshsngh commented
StatusFileSize
new drupal8-remove-form_options_flatten-2341461-1.patch671 bytes
ashutoshsngh’s picture

ashutoshsngh commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: drupal8-remove-form_options_flatten-2341461-1.patch, failed testing.

ashutoshsngh’s picture

ashutoshsngh commented
Status: Needs work » Needs review
StatusFileSize
new drupal8-remove-form_options_flatten-2341461-2.patch939 bytes

Patch updated.

legolasbo’s picture

legolasbo
he/him
Primary language Dutch
Location Middelburg
commented
Parent issue: » #2205673: [META] Remove all @deprecated functions marked "remove before 8.0"
esod’s picture

esod commented
StatusFileSize
new drupal8-remove-form_options_flatten-2341461-6.patch1.01 KB

I read the meta issue to answer my question about removing the deprecated function (https://www.drupal.org/node/2354597). We're not removing the deprecated functions themselves until later.

This patch failed when I tried to apply it so I assume it would fail testing if it were tested again at this time. I've rerolled the patch to hopefully remedy.

Status: Needs review » Needs work

The last submitted patch, 6: drupal8-remove-form_options_flatten-2341461-6.patch, failed testing.

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new 2341461-8.patch938 bytes

Reroll

ashutoshsngh’s picture

ashutoshsngh commented
Status: Needs review » Reviewed & tested by the community

#8 looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

"Code already marked for removal by 8.0.0" is marked as prioritized at https://www.drupal.org/contribute/core/beta-changes#prioritized, so this looks good to go.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed df881ba on 8.0.x 
    Issue #2341461 by ashutoshsngh, esod, quietone: Remove usage of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yesct’s picture

yesct commented
Issue tags: -Novice. @deprecated +Novice, +@deprecated

tags should be separated by a comma