Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.asstes/chosen appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.
The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
Did you modify/hack the chosen files?
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | mollom.asmselect.12.patch | 15.42 KB | eshta |
| #9 | mollom.chosen_remove.9.patch | 95.55 KB | eshta |
| #7 | mollom.chosen_remove.7.patch | 94.95 KB | eshta |
| #5 | mollom.chosen_remove.5.patch | 93.03 KB | eshta |
Comments
Comment #1
eshta commentedHi there,
So in going back memory lane, the assets folder with the third party js got introduced here: https://www.drupal.org/node/2131739#comment-8162559. The justification at the time was that it is only in use on the Mollom settings page and therefore unlikely to conflict. Of course thinking about this, why wouldn't it conflict with the larger template in the design of a site? I don't believe the files are changed at all, but I think the choice was to guarantee their inclusion, perhaps. I agree that the right way forward here if we are to keep a reliance on chosen is to load it via the libraries module.
I think I would approach this as simple a nice to have - in other words - if the libraries module is enabled and chosen is loaded, then use it. Otherwise, we could display a slightly different UI that includes a normal select but with a better indicator of what is already selected so that the languages don't get buried down in the list. We could even include it in the hook_requirements so that the status page gives a hint to what we'd like to see available but without fully enforcing it.
Comment #2
dave reidMollom shouldn't include Chosen. It should be progressively enhanced if the https://www.drupal.org/project/chosen module is enabled, or the library is already included. Basically, Mollom shouldn't do anything and just show a native select box, like the rest of core and contrib manages to do without needing Chosen.
Comment #3
eshta commented@Dave Reid - yup - sounds like we are saying the same thing. I'm hoping to get to this one in the nearer term.
Comment #4
eshta commentedComment #5
eshta commentedHere's a patch to do just that. I believe there is something similar in the d6 version that should also be removed.
Comment #7
eshta commentedD'oh - Making patch binary so that it can apply.
Comment #8
klausiSomething is wrong with this comment sentence :-)
And why do you need function_exists()? Does the function libraries_get_path() only exist in one branch of the libraries module? Please add a comment.
Otherwise looks good.
Comment #9
eshta commentedYeah - that got a bit garbed upon edit. Should be a bit clearer now. Same with the function_exists call -- was left in on an edit and is irrelevant now. I've also added a quick mention to the readme.txt file as an optional installation step.
Comment #10
klausiyay!
Comment #12
eshta commentedYay! Thanks for pointing this out and for the feedback along they. On to D6 we go.
Comment #14
eshta commented