Rest export views preview should show some output instead of 500 [#2340471]

Problem/Motivation

When adding a Rest export to ie http://drupal.d8/index.php/admin/structure/views/view/frontpage/edit/res... the "Auto preview" should display something.

Currently the POST to http://drupal.d8/index.php/admin/structure/views/view/frontpage/preview/... gives error 500

[Thu Sep 18 08:11:02 2014] [error] [client 127.0.0.1] Uncaught PHP Exception Symfony\\Component\\Serializer\\Exception\\UnexpectedValueException: "Serialization for the format drupal_ajax is not supported" at /Users/clemens/Sites/drupal/d8/www/core/vendor/symfony/serializer/Symfony/Component/Serializer/Serializer.php line 77, referer: http://drupal.d8/index.php/admin/structure/views/view/frontpage/edit/rest_export_1

Proposed resolution

Pick the first available "Accepted request formats".

Remaining tasks

User interface changes

API changes

Comment	File	Size	Author
#12	interdiff.txt	2.54 KB	dawehner
#12	serializer-2340471-12.patch	2.3 KB	dawehner
#9	views-2340471-9.patch	3.98 KB	dawehner
#9	views-2340471-do-not-test.patch	3.23 KB	dawehner
#9	interdiff.txt	3.63 KB	dawehner
#6	rest_export_views-2340471-6.patch	759 bytes	clemens.tolboom
#3	rest_export_views-2340471-3.patch	1.43 KB	clemens.tolboom
#1	rest-2340471-1.patch	764 bytes	dawehner

Comments

Comment #1

dawehner

German

commented 18 September 2014 at 07:06

Status:	Active	» Needs review
Issue tags:		+VDC

Status	File	Size
new	rest-2340471-1.patch	764 bytes

Interesting

Comment #2

18 September 2014 at 08:09

Status:

Needs review

» Needs work

The last submitted patch, 1: rest-2340471-1.patch, failed testing.

Comment #3

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 20 September 2014 at 13:23

Status:

Needs work

» Needs review

Status	File	Size
new	rest_export_views-2340471-3.patch	1.43 KB

The test misses preparing the stub with $view->live_preview = TRUE;

Comment #4

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 20 September 2014 at 13:40

Test fails on local

    $this->assertIdentical($actual_json, $expected, 'The expected HAL output was found.');

while the test verbose output looks like hal+json ... not sure why :-(

Comment #5

20 September 2014 at 14:20

Status:

Needs review

» Needs work

The last submitted patch, 3: rest_export_views-2340471-3.patch, failed testing.

Comment #6

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 20 September 2014 at 14:34

Status:

Needs work

» Needs review

Status	File	Size
new	rest_export_views-2340471-6.patch	759 bytes

Wrong thought ... use boolean if ($this->view->preview) {

New patch should lead to 1 fail mentioned in #4

Comment #7

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 21 September 2014 at 08:51

On local I have

strlen($expected) . ":" . strlen($actual_json)
7363:7033

Doing a pretty print $ diff --side-by-side expected-pp.json actual-pp.json | grep \| gives

                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/10"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/9"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/8"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/7"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/6"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/5"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/4"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/3"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/2"
                     "href" : "http://drupal.d8/index.php/use |	                     "href" : "http://drupal.d8/user/2"
               "href" : "http://drupal.d8/index.php/user/2"   |	               "href" : "http://drupal.d8/user/2"
            "href" : "http://drupal.d8/index.php/entity_test/ |	            "href" : "http://drupal.d8/entity_test/1"

Why is index.php added?

Comment #8

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 21 September 2014 at 08:56

A normal curl --user admin:admin --header "Accept: application/hal+json" --request GET http://drupal.d8/node/1 does not insert "index.php/"

Comment #9

dawehner

German

commented 21 September 2014 at 17:50

Status	File	Size
new	interdiff.txt	3.63 KB
new	views-2340471-do-not-test.patch	3.23 KB
new	views-2340471-9.patch	3.98 KB

@clemens.tolboom

Not sure about all your work here is, but afaik the problem is basically that the existing test has a wrong setup.

Comment #10

21 September 2014 at 18:44

Status:

Needs review

» Needs work

The last submitted patch, 9: views-2340471-9.patch, failed testing.

Comment #11

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 22 September 2014 at 06:16

@dawehner np as your change explains my stumbling ;-)

+++ b/core/modules/rest/src/Tests/Views/StyleSerializerTest.php
@@ -60,7 +61,7 @@ protected function setUp() {
-  public function testSerializerResponses() {
+  public function ptestSerializerResponses() {

Huh? Why are most test* functions renamed to ptest* ?

+++ b/core/modules/rest/src/Tests/Views/StyleSerializerTest.php
@@ -259,9 +260,17 @@ public function testFieldRawOutput() {
+      /** @var \Symfony\Component\HttpFoundation\RequestStack $request_stack */

To many whitespace

Comment #12

dawehner

German

commented 22 September 2014 at 08:14

Status:

Needs work

» Needs review

Status	File	Size
new	serializer-2340471-12.patch	2.3 KB
new	interdiff.txt	2.54 KB

Huh? Why are most test* functions renamed to ptest* ?

This is poormanstestaccelerator.

Fixed the issues.

Comment #13

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 27 September 2014 at 09:29

Parent issue:

» #2335229: [meta] REST et al

Comment #14

clemens.tolboom

Dutch

Groningen, 🇳🇱/🇪🇺

commented 27 September 2014 at 14:49

Status:

Needs review

» Reviewed & tested by the community

Comment #15

webchick

she/they

English

Vancouver 🇨🇦

commented 28 September 2014 at 21:17

Status:

Reviewed & tested by the community

» Fixed

Committed and pushed to 8.x. Thanks!

Comment #16

28 September 2014 at 21:17

webchick committed 688f773 on 8.0.x

Issue #2340471 by clemens.tolboom, dawehner: Fixed Rest export views...

Comment #17

12 October 2014 at 21:20

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Rest export views preview should show some output instead of 500

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Parent issue

Referenced by

News items

Our community

Documentation

Drupal code base

Governance of community