Comments

dawehner’s picture

Status: Active » Needs review
Issue tags: +VDC
StatusFileSize
new23.76 KB

Let's give it a first try, though this will probably fail.

Status: Needs review » Needs work

The last submitted patch, 1: views-2340181-1.patch, failed testing.

jhodgdon’s picture

The patch looks to me as though it is trying to do the right thing.

The install fails due to:

PHP Fatal error: Unsupported operand types in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/node/src/NodeViewsData.php on line 282

This is because NodeViewsData is making modifications to various things returned by the base EntityViewsData class, and they don't exist any more, I think?

So it looks like we should get rid of references in NodeFieldData::getViewsData()
- $data['node']['id' or 'vid' or 'type'] (and maybe do the mods there on the node_field_data table fields?)
- $data['node_revision']['id' or 'vid' or 'type'] (and maybe do the mods there on the node_field_revision table fields?)

This should be easy to fix... @dawehner, do you want to do it or shall I?

xjm’s picture

Is this also a duplicate of #2429447: Use data table as views base table, if available. or should it just be postponed on that?

xjm’s picture

Status: Needs work » Closed (duplicate)

Yep it is listed in scope there.