Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
The patch looks to me as though it is trying to do the right thing.
The install fails due to:
PHP Fatal error: Unsupported operand types in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/node/src/NodeViewsData.php on line 282
This is because NodeViewsData is making modifications to various things returned by the base EntityViewsData class, and they don't exist any more, I think?
So it looks like we should get rid of references in NodeFieldData::getViewsData()
- $data['node']['id' or 'vid' or 'type'] (and maybe do the mods there on the node_field_data table fields?)
- $data['node_revision']['id' or 'vid' or 'type'] (and maybe do the mods there on the node_field_revision table fields?)
This should be easy to fix... @dawehner, do you want to do it or shall I?
Comments
Comment #1
dawehnerLet's give it a first try, though this will probably fail.
Comment #3
jhodgdonThe patch looks to me as though it is trying to do the right thing.
The install fails due to:
PHP Fatal error: Unsupported operand types in /var/lib/drupaltestbot/sites/default/files/checkout/core/modules/node/src/NodeViewsData.php on line 282
This is because NodeViewsData is making modifications to various things returned by the base EntityViewsData class, and they don't exist any more, I think?
So it looks like we should get rid of references in NodeFieldData::getViewsData()
- $data['node']['id' or 'vid' or 'type'] (and maybe do the mods there on the node_field_data table fields?)
- $data['node_revision']['id' or 'vid' or 'type'] (and maybe do the mods there on the node_field_revision table fields?)
This should be easy to fix... @dawehner, do you want to do it or shall I?
Comment #4
xjmIs this also a duplicate of #2429447: Use data table as views base table, if available. or should it just be postponed on that?
Comment #5
xjmYep it is listed in scope there.