Follow-up to #2328913: Move block classes out of preprocess and into templates

Problem/Motivation

The block preprocess unit test has been made useless by #2328913: Move block classes out of preprocess and into templates.

Proposed resolution

Remove BlockPreprocessUnitTest.

CommentFileSizeAuthor
#2 remove-block-preprocess-unit-test-2339069-1.patch2.04 KBrgoodine

Comments

rgoodine’s picture

rgoodine commented
Assigned: Unassigned » rgoodine

I'm working on a patch for this.

rgoodine’s picture

rgoodine commented
Status: Active » Needs review
StatusFileSize
new remove-block-preprocess-unit-test-2339069-1.patch2.04 KB

Here's the patch

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Needs review » Reviewed & tested by the community

Nice simple patch. Looks great!

rainbowarray’s picture

rainbowarray
she/her
Primary language English
Location Twin Cities, Minnesota
commented
Status: Reviewed & tested by the community » Needs review

I guess I'll wait to make sure patch comes back green first.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed cf83a52 and pushed to 8.0.x. Thanks!

  • alexpott committed cf83a52 on 8.0.x 
    Issue #2339069 by rgoodine | joelpittet: Remove useless...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.