[PATCH] Blogger Authentication Fix (OpenID 1.1 server compatibility) [#233885]

Comment	File	Size	Author
	openid.module.patch.txt	1.32 KB	techtonik

Comment #1

techtonik CreditAttribution: techtonik commented 16 May 2008 at 11:51

Title:	Fix authentication with Blogger (OpenID 1.1 server compatibility fix)	» [PATCH] Blogger Authentication Fix (OpenID 1.1 server compatibility)
Priority:	Normal	» Critical

Could somebody with write access add this to some release branch finally?

The specific error displayed by Blogger for unpatched Drupal that sends invalid request to 1.1 server is:
error:Invalid AuthRequest: 768: Invalid value for openid.ns field: http://openid.net/signon/1.0

Log in or register to post comments

Comment #2

techtonik CreditAttribution: techtonik commented 20 May 2008 at 06:39

Status:

Needs review

» Reviewed & tested by the community

Log in or register to post comments

Comment #3

boxfire CreditAttribution: boxfire commented 31 August 2008 at 20:38

Could someone possibly have a patch for version 6 please? People who want to move their blogs from blogger and considering drupal would find this very useful. Thanks

Log in or register to post comments

Comment #4

haxney CreditAttribution: haxney commented 27 October 2008 at 19:26

Applying this fix to 6.6 worked for me, though I had to enter my OpenID twice, with the login succeeding on the second try. Annoying, but livable.

Log in or register to post comments

Comment #5

Vacilando CreditAttribution: Vacilando commented 1 November 2008 at 16:57

Same problem in Drupal 6 :-(

chrono325, could you please post your function openid_authentication_request from openid.module. When I tried to apply the D5 patch in my D6.6, it still did not work for me. But D6 openid.module is a bit different, so I would like to see the code that is working for you.

Log in or register to post comments

Comment #6

Russell McOrmond CreditAttribution: Russell McOrmond commented 3 November 2008 at 19:14

I would like to confirm that this problem still existed with openid-5.x-1.2 , and that the patch seemed to allow me to add http://mcormond.blogspot.com/ as an OpenID.

Log in or register to post comments

Comment #7

Leeteq CreditAttribution: Leeteq commented 27 February 2009 at 10:25

Subscribing.

Log in or register to post comments

Comment #8

anarcat CreditAttribution: anarcat commented 18 March 2009 at 03:02

Subscribing.

For D6, it's probably better to resubmit the patch in the Drupal core project itself, and have it ported to D7. Only then it *may* be backported to D6.

Log in or register to post comments

Comment #9

paganwinter CreditAttribution: paganwinter commented 23 March 2009 at 07:24

I have used the above patch.
I get this after getting authenticated from Flickr:

    * E-mail address field is required.
    * Accept Terms & Conditions of Use * field is required.
    * OpenID registration failed for the reasons listed. You may register now, or if you already have an account you can log in now and add your OpenID under "My Account"

The Terms of Condition is coming from the Legal module.
And mail id is a mandatory field for Drupal.
But when i proceeded with the Drupal registration form and register myself, I am shown the OpenId I had provided.

So would it be ok if I just suppress the above message and tell the user that the authentication was successful?
If it's only the above stated 2 reasons, then the user should be able to procedd and fill in the Drupal registration form.
But what if there was some other error that occurred while authentication?
Is there some way of finding that out and only then displaying the Failure notification?