The constructor parameters have changed but the annotations have not been kept in sync

Also a minor correction saveLanguageTypesConfiguration() should use the inhertdoc convention.

CommentFileSizeAuthor
#2 interdiff-0-2.txt1.45 KBmartin107
#2 Configurable-2.patch1.76 KBmartin107
Configurable-0.patch1.29 KBmartin107

Comments

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/language/src/ConfigurableLanguageManager.php
@@ -112,8 +112,8 @@ public static function rebuildServices() {
+   * @param \Symfony\Component\HttpFoundation\RequestStack $requestStack

Meh, you could fix the coding standard of $requestStack to $request_stack

martin107’s picture

martin107 commented
StatusFileSize
new Configurable-2.patch1.76 KB
new interdiff-0-2.txt1.45 KB

Of course, no problem.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 2345f05 and pushed to 8.0.x. Thanks!

  • alexpott committed 2345f05 on 8.0.x 
    Issue #2338055 by martin107: A couple of quirks in the documentation for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.