Add test coverage that locked languages can not be deleted through the UI. LanguageAccessControlHandler ensures the user gets a 403 but this is not tested AFAICS.

CommentFileSizeAuthor
d8.locked-language-delete-test.patch795 bytesalexpott

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +language-base, +sprint

Yeah I tested this manually, it should be good :) Thanks!

yesct’s picture

yesct commented

nice.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, d8.locked-language-delete-test.patch, failed testing.

Status: Needs work » Needs review

alexpott queued d8.locked-language-delete-test.patch for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

HEAD got broke by a commit of #2148199: Use snapshot to warn users if the configuration has changed since last import

  • webchick committed f2f572e on 8.0.x 
    Issue #2336689 by alexpott: Test that a locked language can not be...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Good find, thanks!