Problem/Motivation

#2332389: Finish adding methods to FormStateInterface introduced a small inconsistency:
FormState has public function &getGroups() {
But FormStateInterface has public function getGroups(); without the &

This still works since PHP 5.3.4 (no idea why) but it is confusing for those looking at the interface.

Proposed resolution

Add the missing &

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2336405-form_state-1.patch468 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
2336405-form_state-1.patch468 bytes

We can't really write tests for this AFAIK, since the class is allowed to override the interface.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs review » Reviewed & tested by the community

Thank you for catching this.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 949cb63 and pushed to 8.0.x. Thanks!

  • alexpott committed 949cb63 on 8.0.x 
    Issue #2336405 by tim.plunkett: Fixed Follow-up: FormStateInterface::...
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: tim.plunkett » Unassigned

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.