Problem/Motivation

LinkItem promotes "value" as it's main property, which doesn't even exist.

Proposed resolution

Promote "url" as main property for LinkItem.

Remaining tasks

- review submitted patch

User interface changes

None.

API changes

LinkItem now promotes "url" as it's main property.

CommentFileSizeAuthor
#1 2335775_1.patch548 bytesslashrsm

Comments

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
StatusFileSize
new 2335775_1.patch548 bytes
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Ugh, we should seriously remove the default of 'value', but that's a separate issue. RTBC.

I wondered whether URL actually *is* the main property here, because you can also set the route name etc., but isEmpty() already checks 'url' only, so that seems to be fine.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5d0f259 and pushed to 8.0.x. Thanks!

  • alexpott committed 5d0f259 on 8.0.x 
    Issue #2335775 by slashrsm: Fixed LinkItem should promote "url" as it's...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.