It would be nice to have versions of these to call in our custom code.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2335117-render-cache-view-field.patch | 15.44 KB | dave reid |
It would be nice to have versions of these to call in our custom code.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2335117-render-cache-view-field.patch | 15.44 KB | dave reid |
Comments
Comment #1
dave reidRe-scoped to just field_view_field since that's easier to cache than field_view_value(), the latter accepts an arbitrary item to render instead of actually relying on the field data.
Comment #2
dave reidRevised version that re-uses a bit more code since there was a fair amount of work duplicating the entity rendering/caching code.
Comment #3
dave reidNew version adds support for hijacking views_handler_field_field via the render_cache_views sub-module. Tested and confirmed to work on Views using field displays.
Comment #4
dave reidComment #5
fabianx commentedThis is great! Thanks so much.
The cleanup makes sense to me and the code re-use is nice.
I will probably get to a more detailed review in the next few days.
Comment #6
fabianx commentedCommitted and pushed to 7.x-1.x. Thanks!
I added the following interdiff:
instead of using just 'entity'.
If we need to change this, lets please discuss this in another issue.
Thanks for your great contribution.
This still needs a forward port to 7.x-2.x.
Comment #9
fabianx commentedNvm, I reverted the adding of render_cache: as prefix as its not really needed being in cache_render bin ...
Instead I added the following:
to be consistent with the setting for entities.
Comment #10
geek-merlinSo this is fixed?
Comment #11
fabianx commented#10 Yes, but not yet in 7.x-2.x it seems, so needs to still be ported ... I think ...