Problem/Motivation

Found while working on #2226533: Changes to the Language class due to the LanguageInterface (followup)

Making the id property protected, so... need to not change it in a language like this.

Proposed resolution

Make a new language and use constructor to set the id, or
Maybe we just dont use this change it was thinking it needed to make.

Remaining tasks

see what happens with initial patch
get feedback

User interface changes

No

API changes

No

CommentFileSizeAuthor
#7 2333907.7.patch4.11 KBalexpott
#4 2333907.2.patch1.53 KByesct
#2 2332739.2.patch4.84 KByesct

Comments

yesct’s picture

yesct commented
Issue summary: View changes
Status: Active » Needs review

patch to explain my idea.

yesct’s picture

yesct commented
StatusFileSize
new 2332739.2.patch4.84 KB

uh. and the patch.

Status: Needs review » Needs work

The last submitted patch, 2: 2332739.2.patch, failed testing.

yesct’s picture

yesct commented
StatusFileSize
new 2333907.2.patch1.53 KB

crap. right patch.

yesct’s picture

yesct commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 2333907.2.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
StatusFileSize
new 2333907.7.patch4.11 KB

We can completely remove the user part of the test - it's not really doing much apart from making things complicated - language negotiation, the ability of user's to set timezones and preferred languages are all tested elsewhere.

yesct’s picture

yesct commented

but I wonder if this is testing to see if things are showing in the user preferred language.
Where is "elsewhere"?

I'll look again.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +sprint

This test definitely does not test setting a user preferred language, because even though it sets the user to prefer a language, it does not set the negotiation to include that condition, so it needs to manually fiddle with the interface language to be equal to the user preference, which is the point of this issue... So I agree it just makes the test too complex. UserTimeZoneTest looks like a good test for user timezones that does what this part of this test did. So looks good to me.

yesct’s picture

yesct commented

ok. :)

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0,x, thanks!

  • catch committed 462ba73 on 8.0.x 
    Issue #2333907 by YesCT, alexpott: Fixed FormatDateTest incorrectly...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Yay, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.