EntityDatabaseStorage is the old entity storage and was used for a long time for menu links. Those are converted to content entities now.
There is only one test usage left.
The class could mislead developers to accidently use (for example by extending from it in custom storages), but that will very likely not work, as it doesn't support content entities.
Remove it.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | remove-entitydatabasestorage-2332577-3-interdiff.txt | 1.87 KB | berdir |
| #3 | remove-entitydatabasestorage-2332577-3.patch | 13.26 KB | berdir |
| #1 | remove-entitydatabasestorage-2332577-1.patch | 11.92 KB | berdir |
Comments
Comment #1
berdirRemoved EntityApiInfoTest, that is testing that the entity info cache is cleared and available in hook_modules_installed(), I think we have lots of test coverage now for this and also use it a lot in hooks like that.
Converted the no-bundle test entity to a content entity and extend from EntityTest.
Comment #2
tstoecklerAwesome patch!
I agree that the test is pretty much pointless but I think there must be some code that implements
hook_entity_type_(build|info_alter)()that sets the entity type label. That should be removed as well.Comment #3
berdirTrue, more stuff to remove :)
Comment #4
tstoecklerYes, let's do this! This is really sooo long overdue...
Comment #5
berdirI don't think we need a new change record for this.
I will clean up https://www.drupal.org/node/1400186 and https://www.drupal.org/node/2200867 after it has been committed, especially the first one is very outdated anyway.
Comment #6
alexpottCommitted 055aac1 and pushed to 8.0.x. Thanks!
Comment #8
berdirUpdated the change records, although #1400186: Entities are now classed objects using a defined interface is a pretty hopeless biest, just too old, with too much information by now (list of storage classes and so on).