If I create two pages in the same view, and change the pager for one of them with a restriction to that view, it changes both of them. This appears to be a regression from Views 7.x-3.8.

Steps:
1. Create new Drupal website in simplytest.me (Drupal 8.0.0-alpha14)
2. Go to /admin/structure/views
3. In the row for Recent Content click Edit
4. Click +Add then Block
5. Under Pager, in the row for Use pager, click "10 items'

Actual and expected result: For field reads "This block (override)"

6. Change 10 to 20
7. Click Apply (this display)

Actual: Neither "20 items" nor "Pager" is italicized.
Expected: Either "20 items" or "Pager" is italicized.

8. In the bar at the top below the word "Displays" click the button for Block (as opposed to Block 2)

Actual: Under Pager, in the row for Use pager, it reads "20 items"
Expected: Under Pager, in the row for Use pager, it reads "10 items"

Files: 
CommentFileSizeAuthor
#11 2331793-11.patch3.45 KBolli
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,084 pass(es). View
#11 2331793-11-test.patch1.1 KBolli
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,044 pass(es), 1 fail(s), and 0 exception(s). View
#8 interdiff.txt871 bytesGábor Hojtsy
#8 2331793-8.patch2.35 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,967 pass(es). View
#7 2331793-7.patch1.79 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,971 pass(es). View
#5 2331793-5.patch23.29 KBolli
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,866 pass(es). View
#4 interdiff.txt735 bytesolli
#4 2331793-4.patch23.03 KBolli
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,415 pass(es). View
#3 2331793-3.patch22.62 KBolli
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,417 pass(es). View

Comments

Charles Belov’s picture

Title: Changing pager settings for this display only changes pager settings for other display » Changing pager settings for this display only also changes pager settings for other display
olli’s picture

Version: 8.0.0-alpha14 » 8.0.x-dev
Issue tags: +VDC

There's a similar problem with exposed form settings. It reads "This block (override)" but you are actually changing default values. It looks like pager and exposed form are the only ones with override select element above the settings, other plugins don't have it anymore.

olli’s picture

Status: Active » Needs review
FileSize
22.62 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,417 pass(es). View

This removes pager_options and display dropdown from pager and exposed form plugin settings form.

olli’s picture

FileSize
23.03 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,415 pass(es). View
735 bytes
olli’s picture

FileSize
23.29 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,866 pass(es). View

reroll

Gábor Hojtsy’s picture

Component: views_ui.module » views.module
Status: Needs review » Needs work
Issue tags: +Configuration system, +D8MI, +language-config, +Configuration schema, +sprint, +Needs tests

Extending tags to include ones from #2385107: Cleanup legacy [plugin]_options from views displays which was just marked a duplicate. The test views changes are all included with #2325269: Test and fix views in test_views directories against their configuration schema already, so I would suggest to help that get in (critical :) and then this will be a way smaller patch.

OTOH this one needs tests also. Probably there is a views pager test that can be used to extend a bit. Setting needs work for that.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
1.79 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,971 pass(es). View
Gábor Hojtsy’s picture

FileSize
2.35 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,967 pass(es). View
871 bytes

Also removing pager_options from display defaults and exposed_form_options that got in in #2325269: Test and fix views in test_views directories against their configuration schema only for completeness to be removed here :D

olli’s picture

That's a lot smaller, thanks =)

Not sure yet how to test this but will try to have a look.

dawehner’s picture

This looks great, but to be honest the amount of different issue is a bit confusing to be honest.

olli’s picture

FileSize
1.1 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,044 pass(es), 1 fail(s), and 0 exception(s). View
3.45 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,084 pass(es). View

Here's a small test.

The last submitted patch, 11: 2331793-11-test.patch, failed testing.

olli’s picture

Is there a list of all views config issues?

Gábor Hojtsy’s picture

@olli: Views issues are tagged "VDC", config schema issues are tagged "Configuration schema" so the intersection of those should be what you are looking for: https://www.drupal.org/project/issues/search?projects=&project_issue_fol... if something is not there that is a mistake :)

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community

As for this patch, it looks great. I just rerolled it so I am eligible for review hopefully. :)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed a8a42e6 and pushed to 8.0.x. Thanks!

  • alexpott committed a8a42e6 on 8.0.x
    Issue #2331793 by olli, Gábor Hojtsy: Changing pager settings for this...
Gábor Hojtsy’s picture

Issue tags: -sprint, -Needs tests

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.