If I create two pages in the same view, and change the pager for one of them with a restriction to that view, it changes both of them. This appears to be a regression from Views 7.x-3.8.
Steps:
1. Create new Drupal website in simplytest.me (Drupal 8.0.0-alpha14)
2. Go to /admin/structure/views
3. In the row for Recent Content click Edit
4. Click +Add then Block
5. Under Pager, in the row for Use pager, click "10 items'
Actual and expected result: For field reads "This block (override)"
6. Change 10 to 20
7. Click Apply (this display)
Actual: Neither "20 items" nor "Pager" is italicized.
Expected: Either "20 items" or "Pager" is italicized.
8. In the bar at the top below the word "Displays" click the button for Block (as opposed to Block 2)
Actual: Under Pager, in the row for Use pager, it reads "20 items"
Expected: Under Pager, in the row for Use pager, it reads "10 items"
Comment | File | Size | Author |
---|---|---|---|
#11 | 2331793-11.patch | 3.45 KB | olli |
#11 | 2331793-11-test.patch | 1.1 KB | olli |
#8 | interdiff.txt | 871 bytes | Gábor Hojtsy |
#8 | 2331793-8.patch | 2.35 KB | Gábor Hojtsy |
#7 | 2331793-7.patch | 1.79 KB | Gábor Hojtsy |
Comments
Comment #1
Charles BelovComment #2
olli CreditAttribution: olli commentedThere's a similar problem with exposed form settings. It reads "This block (override)" but you are actually changing default values. It looks like pager and exposed form are the only ones with override select element above the settings, other plugins don't have it anymore.
Comment #3
olli CreditAttribution: olli commentedThis removes pager_options and display dropdown from pager and exposed form plugin settings form.
Comment #4
olli CreditAttribution: olli commentedComment #5
olli CreditAttribution: olli commentedreroll
Comment #6
Gábor HojtsyExtending tags to include ones from #2385107: Cleanup legacy [plugin]_options from views displays which was just marked a duplicate. The test views changes are all included with #2325269: Test and fix views in test_views directories against their configuration schema already, so I would suggest to help that get in (critical :) and then this will be a way smaller patch.
OTOH this one needs tests also. Probably there is a views pager test that can be used to extend a bit. Setting needs work for that.
Comment #7
Gábor HojtsyRerolled now that #2325269: Test and fix views in test_views directories against their configuration schema landed.
Comment #8
Gábor HojtsyAlso removing pager_options from display defaults and exposed_form_options that got in in #2325269: Test and fix views in test_views directories against their configuration schema only for completeness to be removed here :D
Comment #9
olli CreditAttribution: olli commentedThat's a lot smaller, thanks =)
Not sure yet how to test this but will try to have a look.
Comment #10
dawehnerThis looks great, but to be honest the amount of different issue is a bit confusing to be honest.
Comment #11
olli CreditAttribution: olli commentedHere's a small test.
Comment #13
olli CreditAttribution: olli commentedIs there a list of all views config issues?
Comment #14
Gábor Hojtsy@olli: Views issues are tagged "VDC", config schema issues are tagged "Configuration schema" so the intersection of those should be what you are looking for: https://www.drupal.org/project/issues/search?projects=&project_issue_fol... if something is not there that is a mistake :)
Comment #15
Gábor HojtsyAs for this patch, it looks great. I just rerolled it so I am eligible for review hopefully. :)
Comment #16
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed a8a42e6 and pushed to 8.0.x. Thanks!
Comment #18
Gábor HojtsyYay, thanks!