Problem/Motivation

Very minor issue but there is a margin applied to file fields which unnecessarily indents the fields (see attachments).

File field with left indentation.

Proposed resolution

Set the margin to zero for .form-managed-file .form-file but keep the 0.5em margin for .form-managed-file .form-submit.

CommentFileSizeAuthor
#3 drupal-remove_file_field_indentation-2330791-3.patch345 bytestanc
#1 drupal-file_field_indentation-2330791-1.patch395 bytestanc
Create_Article.jpg431.17 KBtanc

Comments

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
Status: Active » Needs review
StatusFileSize
new drupal-file_field_indentation-2330791-1.patch395 bytes

Patch added.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Would be possible to simply remove the selector alltogether? I.e. is there a margin that is being set by a less specific selector?

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
StatusFileSize
new drupal-remove_file_field_indentation-2330791-3.patch345 bytes

Very good point. Attached is a new patch which removes the selector. The less specific selector that controls the margin is the normalize.css based input selector which sets margin to zero.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Awesome. Tested that this does as shown in the screenshot. Thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: drupal-remove_file_field_indentation-2330791-3.patch, failed testing.

Status: Needs work » Needs review

tanc queued 3: drupal-remove_file_field_indentation-2330791-3.patch for re-testing.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Still applies fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 986b32e and pushed to 8.0.x. Thanks!

  • alexpott committed 986b32e on 8.0.x 
    Issue #2330791 by tanc: Fixed Remove indentation on file fields.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.