Caused by #2323721: [sechole] Link field item and menu link information leakage
There was 1 failure:
1) Drupal\Tests\Core\UrlTest::testCreateFromPath
Expectation failed for method name is equal to <string:matchRequest> when invoked at sequence index 2
Parameter 0 for invocation Symfony\Component\Routing\Matcher\RequestMatcherInterface::matchRequest(Symfony\Component\HttpFoundation\Request Object (...)) does not match expected value.
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
'SERVER_PROTOCOL' => 'HTTP/1.1'
- 'REQUEST_TIME' => 1409560322
+ 'REQUEST_TIME' => 1409560323
'PATH_INFO' => ''
'REQUEST_METHOD' => 'GET'
'REQUEST_URI' => '/node/2/edit'
'QUERY_STRING' => ''
)
)
'files' => Symfony\Component\HttpFoundation\FileBag Object (...)
'cookies' => Symfony\Component\HttpFoundation\ParameterBag Object (...)
'headers' => Symfony\Component\HttpFoundation\HeaderBag Object (...)
'content' => null
'languages' => null
'charsets' => null
'encodings' => null
'acceptableContentTypes' => null
'pathInfo' => null
'requestUri' => null
'baseUrl' => null
'basePath' => null
'method' => null
'format' => null
'session' => null
'locale' => null
'defaultLocale' => 'en'
)
/home/chx/www/d8/core/lib/Drupal/Core/Url.php:153
Example random fails
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | url_test-2330751-2.patch | 2.29 KB | dawehner |
Comments
Comment #1
dawehnerThis is one way.
Comment #2
dawehnerLet's get the work done, we talked about in IRC.
Comment #3
chx commentedCore tests:
Symfony tests:
Comment #4
dawehnerSee https://github.com/symfony-cmf/Routing/issues/113
Comment #5
dawehnerNope, all other cases at least in core aren't valid. Those don't actually create a request in the code, so comparing those won't fail
because it is the same object.
Comment #6
chx commentedGot it! Those others pass along the
$requestthey created and not rely on some code to create another request object which causes these failures.Comment #7
dawehnerNope, random test failures are critical, I would say.
Comment #8
yesct commentedComment #9
yesct commentedComment #11
webchickCommitted and pushed to 8.x. Thanks!