Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
routing system
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Sep 2014 at 08:34 UTC
Updated:
21 Sep 2014 at 03:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerThis is one way.
Comment #2
dawehnerLet's get the work done, we talked about in IRC.
Comment #3
chx commentedCore tests:
Symfony tests:
Comment #4
dawehnerSee https://github.com/symfony-cmf/Routing/issues/113
Comment #5
dawehnerNope, all other cases at least in core aren't valid. Those don't actually create a request in the code, so comparing those won't fail
because it is the same object.
Comment #6
chx commentedGot it! Those others pass along the
$requestthey created and not rely on some code to create another request object which causes these failures.Comment #7
dawehnerNope, random test failures are critical, I would say.
Comment #8
yesct commentedComment #9
yesct commentedComment #11
webchickCommitted and pushed to 8.x. Thanks!