Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
In core/modules/entity_reference/css/entity_reference.admin.css we set a small left hand margin on the settings of an entity reference field. Currently, though, we don't remember to take into account RTL layouts. I was going to correct this but, on reflection, I'm not sure we really need to set a margin at all for the field settings to still be readable.
Proposed resolution
As this is the only css in this template, I propose to remove it. See before and after screenshots:
Before
After
Remaining tasks
Requires a review of the attached patch and a review of the entity reference settings to decide if the visual change is acceptable.
User interface changes
The entity reference settings are not indented.
Comments
Comment #1
rachel_norfolkComment #2
rachel_norfolkComment #3
rachel_norfolkComment #4
LewisNyman+1. We should avoid adding these inconsistencies to the admin interface.
Also I have no idea what design purpose this indent fufills
Comment #5
ckrinaPatch applies cleanly and the visual change is done.
+1 to the visual change.
Moving to RTBC.
Comment #6
rachel_norfolkComment #7
webchickYay less code! :)
Committed and pushed to 8.x. Thanks!
Comment #10
YesCT CreditAttribution: YesCT commentedI think the + was a typo. FUDK seems to be the more common tag.