Problem/Motivation

In core/modules/entity_reference/css/entity_reference.admin.css we set a small left hand margin on the settings of an entity reference field. Currently, though, we don't remember to take into account RTL layouts. I was going to correct this but, on reflection, I'm not sure we really need to set a margin at all for the field settings to still be readable.

Proposed resolution

As this is the only css in this template, I propose to remove it. See before and after screenshots:

Before

before screenshot, with left margin

After

before screenshot, with left margin

Remaining tasks

Requires a review of the attached patch and a review of the entity reference settings to decide if the visual change is acceptable.

User interface changes

The entity reference settings are not indented.

Comments

rachel_norfolk’s picture

Issue summary: View changes
rachel_norfolk’s picture

Assigned: rachel_norfolk » Unassigned
Status: Active » Needs review
lewisnyman’s picture

+1. We should avoid adding these inconsistencies to the admin interface.

Also I have no idea what design purpose this indent fufills

ckrina’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new66.94 KB
new90.39 KB

Patch applies cleanly and the visual change is done.
+1 to the visual change.
Moving to RTBC.

rachel_norfolk’s picture

Issue tags: +FUDK
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Yay less code! :)

Committed and pushed to 8.x. Thanks!

  • webchick committed 8bce36b on 8.0.x
    Issue #2330465 by rachel_norfolk: Fixed Remove entity_reference.admin....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

yesct’s picture

Issue tags: -+FUDK

I think the + was a typo. FUDK seems to be the more common tag.