Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Small visual error: The checkbox to enable/disable a module or an extension will not have any margin on its left side on the module page (admin/modules) if the description of the module is too long, or if the screen size is too narrow.
This happens at least on latest Chrome, Safari and Firefox (desktop sizes).
See image:
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | bartik_after.png | 29.23 KB | lauriii |
| #6 | bartik_before.png | 19.82 KB | lauriii |
| #6 | stark_after.png | 20.96 KB | lauriii |
| #6 | stark_before.png | 14.21 KB | lauriii |
| #1 | system-enable_disable-2330251-1.patch | 387 bytes | seiplax |
Comments
Comment #1
seiplax CreditAttribution: seiplax commentedAdding patch that adds a min-width of 25px for #system-modules td.checkbox
Result:
Comment #2
rteijeiro CreditAttribution: rteijeiro commentedI cannot reproduce the issue. Could you provide some steps and more info about it, please?
Comment #3
seiplax CreditAttribution: seiplax commentedThis is on 8.0.x (HEAD is now at f6312b8) and no changes made.
To reproduce: Go to admin/config page and check the list of core modules, field types, multilingual and web services. Resize the window so that it is less than 1130px (with navbar horizontal). At that point the checkbox is already without margin. (The mobile view is ok)
You will not see the problem for field types, multilingual or web services (in English) since the text describing them is short. If you edit the DOM and make it longer you will see the checkbox behave the same way.
My Chrome version is 37.0.2062.94 Mac.
This is the checkbox (td class) computed CSS from the DOM - see any difference there if the steps above did not help in reproducing?
border-collapse: collapse;
color: rgb(92, 92, 91);
display: table-cell;
font-family: 'Lucida Grande', 'Lucida Sans Unicode', 'DejaVu Sans', 'Lucida Sans', sans-serif;
font-size: 12px;
font-style: normal;
font-variant: normal;
font-weight: normal;
height: 20px;
line-height: 20px;
margin-bottom: 0px;
margin-left: 5px;
margin-right: 5px;
margin-top: 0px;
padding-bottom: 10px;
padding-left: 0px;
padding-right: 12px;
padding-top: 10px;
text-align: center;
vertical-align: top;
white-space: normal;
width: 12px;
Also tried a fresh install with the minimal install setup, and just seven theme enabled. Same behaviour.
Checked what alpha14 looked like on simplytest.me and got the same result. Checked that on an other computer and got the same result.
Comment #4
lauriiiI can triage the bug. I tested this in all view ports and it doesn't break anything. For me this is RTBC.
Here's before and after screenshots:
Before:
After:
Comment #5
webchickOh, awesome! This has been driving me nuts.
However, since this affects System module's CSS (and thus all themes), can we get a quick check in Stark and Bartik, not just Seven?
Comment #6
lauriiiI tested all Bartik, Stark and Seven in every view-port and everything seems to be alright after patch.
Stark:
Before:
After:
Bartik:
Before:
After:
Comment #7
alexpottCommitted 1c2e4c5 and pushed to 8.0.x. Thanks!