Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is no hook_uninstall to delete all the variables created by this module. I'd suggest implementing hook_uninstall for the cleanup. find a batch attached for that
Comment | File | Size | Author |
---|---|---|---|
#4 | date_popup_authored-2329773-3.patch | 3.78 KB | Mark Trapp |
#4 | date_popup_authored-2329773-3-tests-only.patch | 2.18 KB | Mark Trapp |
Comments
Comment #1
Mark TrappThis is a good idea, and thanks for providing a patch!
Just a few housekeeping notes:
Now for your patch:
<?php
and the top docblock, and there's a missing blank line at the end of the file.Comment #2
amagdy CreditAttribution: amagdy commentedThank you for clearing this up.
I've been putting too many hours into fixing my formatting but I still can't get it 100% correct.
Right now I've PhpStorm with phpSniffer configured with Drupal Standards from Coder Module.
It helps me this way https://www.dropbox.com/s/87blsug320d1sfv/Screenshot%202014-11-24%2010.4...
I wonder what tool do you use to help you with formatting? or do you just memorize every single rule :D
Comment #4
Mark TrappHey, sorry for the late reply!
My process for following the Drupal coding standards has been to eventually memorize them through repetition and practice, and give my code a once-over comparing it to the docs before committing. Your patch was almost there: the stuff I mentioned in my previous comment are the only parts where your patch deviated.
I did another review, and besides the variable cleanup during content type removal, we need tests for this change. I went ahead and added both, then committed the final result. I attached two patch files: one with just the tests and one with everything—here so you can take a look.
The changes will be part of the next beta that I plan on rolling in a day or two.
Thanks again for the good idea and patch!
Comment #5
Mark Trapp