Problem/Motivation

The abstract class PathListenerBase is completely dead code. Neither of the two contained methods (setPath() and extractPath()) are used anywhere throughout the code base. As far as I can tell this is a left over from the refactoring done in #1910318: Make path resolution the responsibility of a series of PathProcessor classes, rather than one PathSubscriber class.

As a bonus, removal of this class also kills two occurrences of _system_path.

Proposed resolution

Remove it.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2329653-remove-path-listener-base.patch1.43 KBznerol

Comments

znerol’s picture

znerol commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2329653-remove-path-listener-base.patch1.43 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Indeed the PathSubscriber has all the logic, so there is no need for a base class. Having one place also makes it easier to remove it in the future.

Nice work!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • webchick committed 9528aed on 8.0.x 
    Issue #2329653 by znerol: Remove left over abstract class...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.