Presumably after converting perms to YAML.

Dawehner said it was ok to assign to him.

CommentFileSizeAuthor
#2 permission-list-node-after-patch.png65.64 KBvijaycs85
#1 2329429.patch4.44 KBdawehner
Screen Shot 2014-08-28 at 1.26.53 PM.png58.48 KBwebchick

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2329429.patch4.44 KB

There we go.

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new permission-list-node-after-patch.png65.64 KB

Looks good now.

+++ b/core/modules/user/tests/src/PermissionHandlerTest.php
@@ -124,6 +124,7 @@ public function testBuildPermissionsModules() {
+

Minor: no need of this empty line?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Yay! Thanks for the quick turnaround.

Committed and pushed to 8.x. Thanks!

  • webchick committed 3b8307b on 8.0.x 
    Issue #2329429 by dawehner: Fixed Permission page order is all wackadoo.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.