Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 route_match-2329303-1.patch4.88 KBdawehner
#4 2329303-theme-4-FAIL.patch966 bytesdawehner
#4 interdiff.txt2.02 KBdawehner
#4 2329303-theme-4.patch4.22 KBdawehner
#7 route-2329303-7-PASS.patch4.25 KBtim.plunkett
#7 route-2329303-7-FAIL.patch999 bytestim.plunkett
#7 interdiff.txt727 bytestim.plunkett

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new route_match-2329303-1.patch4.88 KB
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new route_match-2329303-2.patch3.27 KB

This time a proper patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +Needs tests

Thanks @dawehner!
This blocks page_manager work, see #2329273: Test failure in PageManagerAdminTest

  1. +++ b/core/lib/Drupal/Core/Routing/StackedRouteMatchInterface.php
@@ -0,0 +1,40 @@
+  public function getCurrentRouteMatch();
...
+  public function getMasterRouteMatch();
...
+  public function getParentRequest();

    Shouldn't the last one be getParentRouteMatch?

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2329303-theme-4-FAIL.patch966 bytes
new interdiff.txt2.02 KB
new 2329303-theme-4.patch4.22 KB

Oh shit, you are totally right.

The last submitted patch, 4: 2329303-theme-4-FAIL.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2329303-theme-4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs tests
StatusFileSize
new interdiff.txt727 bytes
new route-2329303-7-FAIL.patch999 bytes
new route-2329303-7-PASS.patch4.25 KB

Awesome @dawehner! This works perfectly.

Just fixing the passing test to use the right permission.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: use the right request when determine the theme on a 403 page » Use the right request when determining the theme on a 403 page
Priority: Normal » Major
Issue tags: +Page Manager

The last submitted patch, 7: route-2329303-7-FAIL.patch, failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • webchick committed 469fe97 on 8.0.x 
    Issue #2329303 by tim.plunkett, dawehner: Fixed Use the right request...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.