Problem/Motivation

SummaryLengthTest::testSummaryLength() directly sets WebTestBase::loggedInUser for no reason and without any effect.

Proposed resolution

Remove it.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2329009-do-not-alter-logged-in-user.patch2 KBznerol

Comments

znerol’s picture

znerol commented
Status: Active » Needs review
StatusFileSize
new 2329009-do-not-alter-logged-in-user.patch2 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Yep, drupalBuildEntityView() and others does not use this permissions and it's wrong to set the variable this way

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Hm. Bizarre. Nice catch again. ;) Only thing I can think is this was originally part of a larger test that also tried changing the length in the admin screen and seeing what happened. Oh well...

Committed and pushed to 8.x. Thanks!

  • webchick committed 403b56b on 8.0.x 
    Issue #2329009 by znerol: Fixed SummaryLengthTest::testSummaryLength()...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.