Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Aug 2014 at 17:08 UTC
Updated:
2 Sep 2014 at 21:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
marvil07 commentedHere the patch.
Comment #2
jhodgdonUm... What does this setting actually do? If it's TRUE, what effect does it have? I guess I don't know from reading this documentation what "extension discovery" is or how it would affect my install of Drupal. An additional line explaining this could be useful.
Comment #3
marvil07 commentedThanks for the review.
Here a new version with a little more explanation.
Comment #4
jhodgdonBetter! How about this small tweak to the wording:
This setting enables the inclusion of test extensions during extension discovery; i.e., it forces discovery of modules under 'tests' directories.
Also, just to clarify: did you mean "i.e." (that is) or "e.g." (for example) here? In other words, is it just modules in tests directories that are discovered, or are there other examples of things that are discovered when you turn this on? If it's really "i.e.", then this could be simplified to say:
This setting forces discovery of modules under 'tests' directories, which are normally ignored during extension discovery.
If it's really e.g., then probably it's best to write out "for example", because (as in this case) this is often confused with i.e. and writing it out in words is clearer.
Comment #5
marvil07 commentedThanks for the question, I actually read some more code and now it is really clear: it just excludes the tests directory(see RecursiveExtensionFilterIterator::acceptTests()).
So, I changed the text to be coherent with it.
Comment #6
jhodgdonAgreed, this is very clear, thanks! Nitpick: there should be a comma after "for example", if you're going to use a ; before it. Or change the ; to a , and then you're OK.
So it should be either one of these:
... directory, for example a module ...
... directory; for example, a module ...
Comment #7
marvil07 commentedThanks for the correction, here the new version.
Comment #8
dawehnerThat's a duplicate of #2327095: Document how to allow test module and theme installation in example.settings.local.php which is already RTBC
Comment #9
dawehnerYou could merge the commit message if you care.