Problem/Motivation

In order to answer: Why my test modules are not detected?
I needed to read all the info parsing logic.

Proposed resolution

Document the existing setting.

Remaining tasks

Add docs.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#7 interdiff.txt521 bytesmarvil07
#7 2328667-7.patch924 bytesmarvil07
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,606 pass(es). View
#5 interdiff.txt619 bytesmarvil07
#5 0001-Issue-2328667-by-marvil07-jhodgdon-Documents-extensi.patch924 bytesmarvil07
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,263 pass(es). View
#3 interdiff.txt489 bytesmarvil07
#3 0001-Issue-2328667-by-marvil07-Documents-extension_discov.patch936 bytesmarvil07
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,242 pass(es). View
#1 0001-Issue-2328667-by-marvil07-Documents-extension_discov.patch774 bytesmarvil07
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,243 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

marvil07’s picture

Assigned: marvil07 » Unassigned
Issue summary: View changes
Status: Active » Needs review
FileSize
774 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,243 pass(es). View

Here the patch.

jhodgdon’s picture

Um... What does this setting actually do? If it's TRUE, what effect does it have? I guess I don't know from reading this documentation what "extension discovery" is or how it would affect my install of Drupal. An additional line explaining this could be useful.

marvil07’s picture

FileSize
936 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,242 pass(es). View
489 bytes

Thanks for the review.

Here a new version with a little more explanation.

jhodgdon’s picture

Status: Needs review » Needs work

Better! How about this small tweak to the wording:

This setting enables the inclusion of test extensions during extension discovery; i.e., it forces discovery of modules under 'tests' directories.

Also, just to clarify: did you mean "i.e." (that is) or "e.g." (for example) here? In other words, is it just modules in tests directories that are discovered, or are there other examples of things that are discovered when you turn this on? If it's really "i.e.", then this could be simplified to say:

This setting forces discovery of modules under 'tests' directories, which are normally ignored during extension discovery.

If it's really e.g., then probably it's best to write out "for example", because (as in this case) this is often confused with i.e. and writing it out in words is clearer.

marvil07’s picture

Status: Needs work » Needs review
FileSize
924 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,263 pass(es). View
619 bytes

Thanks for the question, I actually read some more code and now it is really clear: it just excludes the tests directory(see RecursiveExtensionFilterIterator::acceptTests()).

So, I changed the text to be coherent with it.

jhodgdon’s picture

Status: Needs review » Needs work

Agreed, this is very clear, thanks! Nitpick: there should be a comma after "for example", if you're going to use a ; before it. Or change the ; to a , and then you're OK.

So it should be either one of these:
... directory, for example a module ...
... directory; for example, a module ...

marvil07’s picture

Status: Needs work » Needs review
FileSize
924 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,606 pass(es). View
521 bytes

Thanks for the correction, here the new version.

dawehner’s picture

Status: Needs review » Closed (duplicate)
dawehner’s picture

You could merge the commit message if you care.