Part of #2285413: [Meta] Standardize entity route names
See there for details.

CommentFileSizeAuthor
#11 interdiff.txt6.13 KBdawehner
#11 views-2327373-11.patch23.89 KBdawehner
#9 interdiff.txt5 KBdawehner
#9 views-2327373-9.patch20.65 KBdawehner
#7 interdiff.txt6.74 KBdawehner
#7 views-2327373-7.patch18.26 KBdawehner
#2 2327373-2.patch14.29 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Assigned: Unassigned » dawehner

.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Assigned: dawehner » Unassigned
Status: Active » Needs review
FileSize
2327373-2.patch14.29 KB

Let's try it out.

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

Visually seems OK skimming it over. Bot can object if it wants.

Crell’s picture

Crell CreditAttribution: Crell commented
Parent issue: » #2285413: [Meta] Standardize entity route names
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Issue summary: View changes 
+++ b/core/modules/views_ui/views_ui.routing.yml
@@ -64,7 +64,7 @@ views_ui.disable:
-views_ui.duplicate:
+entity.view.duplicate:
...
     _entity_form: 'view.duplicate'

@@ -125,7 +125,7 @@ views_ui.preview:
-views_ui.break_lock:
+entity.view.break_lock:
...
     _entity_form: 'view.break_lock'

I'd prefer to see '_form' suffix for this names

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2327373-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-2327373-7.patch18.26 KB
interdiff.txt6.74 KB

Renamed those.

Status: Needs review » Needs work

The last submitted patch, 7: views-2327373-7.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
Issue tags: +VDC
FileSize
views-2327373-9.patch20.65 KB
interdiff.txt5 KB

Some work, not done yet.

Status: Needs review » Needs work

The last submitted patch, 9: views-2327373-9.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-2327373-11.patch23.89 KB
interdiff.txt6.13 KB

@andypost
Enable/disable aren't really forms, they are just AJAX GET callbacks.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +WSCCI

Awesome, all routes are standardized!!!

PS: as this issue is the last, I'm closing parent #2285413: [Meta] Standardize entity route names major--

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x .Thanks!

  • webchick committed 777bc65 on 8.0.x 
    Issue #2327373 by dawehner: Standardize view entity route names.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.