Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
file.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 Aug 2014 at 14:46 UTC
Updated:
5 Nov 2014 at 09:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettWorking on this
Comment #2
tim.plunkettComment #4
tim.plunkettRerolled for now without the hook_element_info() removal in light of #2326409: Annotate render element plugins
Comment #6
tim.plunkettComment #8
tim.plunkettfile_managed_file_validate() was used in one other place.
Comment #10
tim.plunkettComment #11
jibranWe can use static method here.
Comment #12
tim.plunkettOkay
Comment #15
tim.plunkettDuh! We need to specify the #value_callback until its a proper callback.
Comment #16
tim.plunkettComment #17
jibranIf you disagree with 1 and 2 it's fine by me perhaps we can add @todo (with issue id) for those methods.
IMO we can also move this function here.
IMO we have to move this function as well to this element file. Right know we are not using it at anyplace other then this.
Can't we use controller/routes here?
Minor doc update
file_managed_file_processdoesn't exist anymore andfrom_builderis deprecated. There is one more ref tofile_managed_file_processjust abovefile_managed_file_submitwe have to update that as well.Comment #18
imiksuThis should resolve #17.4.
Comment #19
tim.plunkettComment #22
jibranthis issue is in so needs reroll.
Comment #23
tim.plunkettComment #24
jibranThank you married guy :D
Comment #25
alexpottCommitted 69be11e and pushed to 8.0.x. Thanks!