Move classes out of the preprocess functions and into the Twig templates.

Twig Templates Modified

region.html.twig

Preprocess Functions Modified

template_preprocess_region

CommentFileSizeAuthor
#1 consensus_banana_phase-2326423-1.patch1.7 KBwheatpenny
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wheatpenny’s picture

wheatpenny CreditAttribution: wheatpenny commented
Status: Needs work » Needs review
FileSize
consensus_banana_phase-2326423-1.patch1.7 KB
wheatpenny’s picture

wheatpenny CreditAttribution: wheatpenny commented
Title: Consensus Banana Phase 1: Move "region" classes from preprocess to template » Move "region" classes from preprocess to template

Editing title based on feedback from #2322287: Move datetime classes from preprocess to template.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Status: Needs review » Reviewed & tested by the community

Looks good!

mortendk’s picture

mortendk CreditAttribution: mortendk commented

+1

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented

Just manually tested this one as well to confirm, absolutely no markup changes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed d81f06f and pushed to 8.0.x. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed d81f06f and pushed to 8.0.x. Thanks!

  • alexpott committed d81f06f on 8.0.x 
    Issue #2326423 by wheatpenny: Move "region" classes from preprocess to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.