field.module's field.schema.yml contains schema info about field types provided by Core.

Those should move somewhere else - system.schema.yml I guess ?

CommentFileSizeAuthor
#4 2325999-4.patch7.79 KBswentel

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Until, recently, that made sense to me, because it was the schema *for* field.module config entities, it did not exist anywhere else.

That changed recently with the core base field override config entity, so yes, I think it should move.

swentel’s picture

swentel commented

Can't we move them into core/config/schema ?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

move them into core/config/schema

+1

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 2325999-4.patch7.79 KB
yched’s picture

yched commented
Status: Needs review » Reviewed & tested by the community

Thanks !

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This is a pre-existing condition, since the patch is just moving things around, but it's weird that Email is an optional module and yet its schema is defined by core. Then again, I see EmailItem.php is also under core/lib/Drupal/Core/Field/Plugin/Field/FieldType/ along with the rest of these, so I guess it's fine. Heh. And apparently I also made up that Email is a module at all, so ignore me altogether. ;P

Anyway, this moves stuff to the closest equivalent to where it's defined, so makes sense.

Committed and pushed to 8.x. Thanks!

  • webchick committed 7e7c715 on 
    Issue #2325999 by swentel: Move config schema for Core field types out...
yched’s picture

yched commented

@webchick: yeah, email was a plugins-only module at some point, and was moved to Core as part of the "deduplicate field types" meta. Users require an email field, that was a lame module dependency...

Last time I checked, telephone.module could go the same way (even though no core entity type require that one)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.