field.module's field.schema.yml contains schema info about field types provided by Core.
Those should move somewhere else - system.schema.yml I guess ?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2325999-4.patch | 7.79 KB | swentel |
field.module's field.schema.yml contains schema info about field types provided by Core.
Those should move somewhere else - system.schema.yml I guess ?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2325999-4.patch | 7.79 KB | swentel |
Comments
Comment #1
berdirUntil, recently, that made sense to me, because it was the schema *for* field.module config entities, it did not exist anywhere else.
That changed recently with the core base field override config entity, so yes, I think it should move.
Comment #2
swentel commentedCan't we move them into core/config/schema ?
Comment #3
sun+1
Comment #4
swentel commentedComment #5
yched commentedThanks !
Comment #6
webchickThis is a pre-existing condition, since the patch is just moving things around, but it's weird that Email is an optional module and yet its schema is defined by core. Then again, I see EmailItem.php is also under core/lib/Drupal/Core/Field/Plugin/Field/FieldType/ along with the rest of these, so I guess it's fine.Heh. And apparently I also made up that Email is a module at all, so ignore me altogether. ;PAnyway, this moves stuff to the closest equivalent to where it's defined, so makes sense.
Committed and pushed to 8.x. Thanks!
Comment #8
yched commented@webchick: yeah, email was a plugins-only module at some point, and was moved to Core as part of the "deduplicate field types" meta. Users require an email field, that was a lame module dependency...
Last time I checked, telephone.module could go the same way (even though no core entity type require that one)