Doctrine v1.2.0 contains the dangling comma fix we use https://github.com/doctrine/annotations/commit/d9b1a37e9351ddde1f19f09a0... and we could/should move to that instead of using a fixed rev.

Should be as simple as editing composer.json

"doctrine/annotations": "1.2.*"

run composer.update doctrine/annotations and then submit the results.

CommentFileSizeAuthor
#5 D8-update_doctrine_annotation-2325779-5.patch125.56 KBastrocling

Comments

not_chx’s picture

not_chx commented
Issue summary: View changes
Issue tags: +Novice
dawehner’s picture

dawehner
Primary language German
commented

#2303673: Implement stackphp; cleanup handlePageCache() and preHandle() will conflict with this, let's just wait.

astrocling’s picture

astrocling commented
Assigned: Unassigned » astrocling

I will work on this when #2303673 is complete

dawehner’s picture

dawehner
Primary language German
commented

Cool!

astrocling’s picture

astrocling commented
Assigned: astrocling » Unassigned
Status: Active » Needs review
StatusFileSize
new D8-update_doctrine_annotation-2325779-5.patch125.56 KB

Ok I updated doctrine/annotations to 1.2.*

Attached is the patch. It is pretty big, so I hope that is ok, if not let me know what I need to do.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 04e4f03 and pushed to 8.0.x. Thanks!

  • alexpott committed 04e4f03 on 8.0.x 
    Issue #2325779 by astrocling | not_chx: Upgrade to Doctrine v1.2.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.