Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Aug 2014 at 18:07 UTC
Updated:
3 Oct 2014 at 09:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
asif_khan commentedhi
i found another issue Replace all calls to _theme with calling \Drupal::theme()->render() i think it's a duplicate issue.
ok i've change 6 calls out of 7 callsof _theme() to \Drupal::theme()
Comment #2
asif_khan commentedComment #3
dawehnerPerfect, thank you for also finding the duplicate issue!
Comment #5
asif_khan commentedComment #6
dawehnerI think this is fine for now
Comment #7
alexpott"service container" is this not just a service? Plus line wrapping.
This call in drupal_render() can be replaced too.
We should also have a followup to move _theme, template_preprocess and _template_preprocess_default_variables into one of the Theme services.
Comment #8
dawehnerHere is a follow up #2340341: Move template_preprocess, _template_preprocess_default_variables into services
@asif_khan
Do you want to try to fix the points from alex's review?
Comment #9
omers commentedOk here is the patch with the fix, hope it works :)
Comment #10
omers commentedComment #11
dawehnerGreat!
Comment #12
alexpottCommitted e92eb2d and pushed to 8.0.x. Thanks!
Comment #13
alexpottCommitted 4d82422 and pushed to 8.0.x. Thanks!
Comment #15
omers commentedTHANK YOU GUYS !!! I hope to contribute my two cents in #2340341 :)
Comment #16
star-szrMinor, but why is this one Drupal and not \Drupal?
Comment #17
alexpott#16 it's a mistake - I should have caught it. We need a small follow-up (in this issue) to address that - feel free to rtbc straight away.
Comment #18
omers commentedOMG sorry about that ... my mistake, i don't know how to proceed when the patch is pushed, but here is the fix.
Comment #19
star-szrWe just need a patch for that one line change, not all the changes that have already been committed. Thanks!
Comment #20
omers commentedHere is :)
Comment #21
omers commentedComment #22
omers commentedComment #23
star-szrGreat, thanks @omers!
Comment #24
alexpottCommitted c58bca3 and pushed to 8.0.x. Thanks!