Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
contextual.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Aug 2014 at 15:57 UTC
Updated:
7 Oct 2014 at 05:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
almaudoh commentedComment #2
almaudoh commentedHere goes...
Comment #3
almaudoh commentedTestbot.
Comment #5
almaudoh commentedComment #9
tim.plunkettPlease include a blank line at the beginning and end of the class
These should be typehinted with array
You just removed this, don't @see it :)
Comment #10
almaudoh commented#9: 1, 2, 3 fixed. Should contextual links and link placeholders be render elements instead of form elements?
Comment #12
tim.plunkettAh, I didn't notice that. Yes, if they don't have #input => TRUE, they are RenderElements.
Comment #13
almaudoh commentedUpdated patch to subclass RenderElement.
Comment #14
tim.plunkettPlease also change the annotation. Thanks!
Comment #15
almaudoh commentedOops! :) Fixed.
Interdiff is against #10.
Comment #17
tim.plunkettExcellent work @almaudoh! If this weren't horribly blocked by #2326409: Annotate render element plugins, it'd be RTBC.
Comment #19
almaudoh commentedThanks @tim.plunkett. Sorry I've been AFK for a couple of days. I'll see how I can help over at #2326409: Annotate render element plugins and #2327965: drupal_flush_all_caches() doesn't clear all plugin caches. I'd be happy to discuss on IRC from wednesday (or on the issue queue from today) on what to do.
Comment #20
almaudoh commentedRerolled #15 and added patch from #2327965-1: drupal_flush_all_caches() doesn't clear all plugin caches to confirm that the tests will pass. No interdiff since there's no change.
Comment #22
tim.plunkettRerolled for now without the hook_element_info() removal in light of #2326409: Annotate render element plugins
Comment #24
tim.plunkettComment #25
jibranNW for #2.
I'd love to see this issue get fixed.
I thought we can inject these but @tim.plunkett gave some valid points in irc and I think it needs little more discussion. So NW for this sorry.
More then 80 chars.
Comment #26
tim.plunkettComment #27
jibranThank you @tim.plunkett for fixing the issues.
We can use
Html::getClass($class);here.Other then this we this is done so RTBC.
Comment #28
webchickCommitted and pushed to 8.x. Thanks!