Problem/Motivation

See parent issue

Proposed resolution

Remaining tasks

User interface changes

API changes

Comments

tim.plunkett’s picture

Status: Active » Needs review
StatusFileSize
new2.52 KB

Status: Needs review » Needs work

The last submitted patch, 1: vdc-2325185-1.patch, failed testing.

The last submitted patch, 1: vdc-2325185-1.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new620 bytes
new3.13 KB

Fix courtesy of @dawehner.

Status: Needs review » Needs work

The last submitted patch, 4: views-2325185-4.patch, failed testing.

dawehner’s picture

StatusFileSize
new3.14 MB

Just ran the test locally using the simpletest UI. You get back this actual error:

Drupal\Component\Plugin\Exception\PluginException: Plugin (view) instance class "Drupal\views\Element\View" does not exist. in Drupal\Component\Plugin\Factory\DefaultFactory::getPluginClass() (line 70 of /var/www/d8/core/lib/Drupal/Component/Plugin/Factory/DefaultFactory.php).

Drupal\Component\Plugin\Factory\DefaultFactory::getPluginClass('view', Array)
Drupal\Core\Plugin\Factory\ContainerFactory->createInstance('view', Array)
Drupal\Component\Plugin\PluginManagerBase->createInstance('view', Array)
Drupal\Core\Render\ElementInfoManager->createInstance('view')
Drupal\Core\Render\ElementInfoManager->buildInfo()
Drupal\Core\Render\ElementInfoManager->getInfo('page')
element_info('page')
Drupal\Core\Page\DefaultHtmlPageRenderer::renderPage('Configuration synchronization has encountered an error.Please continue to the error page', 'Synchronizing configuration', 'maintenance', Array)
_batch_progress_page()
_batch_page(Object)
Drupal\system\Controller\BatchController->batchPage(Object)
call_user_func_array(Array, Array)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1)
Drupal\Core\DrupalKernel->handle(Object)

So there is actually a different error triggered first, which potentially is not caught at all by the bot?

Did a little bit more debugging, see attached HTML. If you look for "0000000057b2b26500007f6b7684c99e" you will see that the registered namespaces
don't have the new enabled modules. While a little bit above, the namespaces are there. This is something I can't really understand at all ...

dawehner’s picture

have you tried running a config import - ie install standard, export config, reinstall minimal, hack site uuid, and run import?

Tip from alex

This fails completly as somehow route rebuilding initializes the search_page entity due to reflection, though that one does not exist yet, for some reason.
Could be a similar cache clear order problem.

tim.plunkett’s picture

Here's what I'm seeing:

The import batch UI is showing "Synchronising extensions: uninstall minimal."

RouterRebuildSubscriber is running thanks to KernelEvents::TERMINATE.
SearchPageRoutes runs, tries to consult SearchPageRepository, which loads the storage for 'search_page', which is not present in EntityManager::getDefinitions() yet.

This is not affected by #2300131: EntityResolverManager instantiates objects unnecessarily, since we don't ever get that far.

I guess module services are registered before caches can clear? I have to go for now and can't work on it more, but that seems to be the problem.

Also, how the hell is this only triggered by this patch!?

sun’s picture

Most likely unrelated/OT, but note that unset($this->property); is not the same as $this->property = NULL; (or whatever the declared default value is) — the former truly unsets the property (as if it were a thing that you could "remove" entirely), the latter resets the value of the property.

The ConfigImporter performs some special re-injection of some services into itself, so an unset/removed property might be related, but that would be a unlucky coincidence, so I doubt that this is the cause.

tim.plunkett’s picture

dawehner’s picture

Status: Needs work » Needs review
StatusFileSize
new5.13 KB

Just an idea, which kinda slows it down like hell.

Status: Needs review » Needs work

The last submitted patch, 12: 2325185.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new2.55 KB

Rerolled for now without the hook_element_info() removal in light of #2326409: Annotate render element plugins

Status: Needs review » Needs work

The last submitted patch, 14: 2325185-view-14.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
StatusFileSize
new2.62 KB
new458 bytes
jibran’s picture

Status: Needs review » Reviewed & tested by the community

Simple enough so RTBC,

+++ b/core/modules/views/src/Element/View.php
@@ -0,0 +1,51 @@
+ *   RenderElement("view")

I didn't know about this.

  • webchick committed eb23f0e on 8.0.x
    Issue #2325185 by dawehner, tim.plunkett: Convert views_element_info()...
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.