Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Aug 2014 at 07:07 UTC
Updated:
7 Oct 2014 at 04:50 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettComment #4
tim.plunkettFix courtesy of @dawehner.
Comment #6
dawehnerJust ran the test locally using the simpletest UI. You get back this actual error:
So there is actually a different error triggered first, which potentially is not caught at all by the bot?
Did a little bit more debugging, see attached HTML. If you look for "0000000057b2b26500007f6b7684c99e" you will see that the registered namespaces
don't have the new enabled modules. While a little bit above, the namespaces are there. This is something I can't really understand at all ...
Comment #7
dawehnerTip from alex
This fails completly as somehow route rebuilding initializes the search_page entity due to reflection, though that one does not exist yet, for some reason.
Could be a similar cache clear order problem.
Comment #8
tim.plunkettMaybe related: #2229303: Enable/add of search pages leads to route not found exception #2230091: Route rebuilding is not guaranteed to finish in time for the next request
Comment #9
tim.plunkettHere's what I'm seeing:
The import batch UI is showing "Synchronising extensions: uninstall minimal."
RouterRebuildSubscriber is running thanks to KernelEvents::TERMINATE.
SearchPageRoutes runs, tries to consult SearchPageRepository, which loads the storage for 'search_page', which is not present in EntityManager::getDefinitions() yet.
This is not affected by #2300131: EntityResolverManager instantiates objects unnecessarily, since we don't ever get that far.
I guess module services are registered before caches can clear? I have to go for now and can't work on it more, but that seems to be the problem.
Also, how the hell is this only triggered by this patch!?
Comment #10
sunMost likely unrelated/OT, but note that
unset($this->property);is not the same as$this->property = NULL;(or whatever the declared default value is) — the former truly unsets the property (as if it were a thing that you could "remove" entirely), the latter resets the value of the property.The ConfigImporter performs some special re-injection of some services into itself, so an unset/removed property might be related, but that would be a unlucky coincidence, so I doubt that this is the cause.
Comment #11
tim.plunkettSee #2326409: Annotate render element plugins for the exception issue.
Comment #12
dawehnerJust an idea, which kinda slows it down like hell.
Comment #14
tim.plunkettRerolled for now without the hook_element_info() removal in light of #2326409: Annotate render element plugins
Comment #16
tim.plunkettComment #17
jibranSimple enough so RTBC,
I didn't know about this.
Comment #19
webchickCommitted and pushed to 8.x. Thanks!