setSetting('default_value') => setDefaultValue()

CommentFileSizeAuthor
#5 menu-2324825-5-test-only.patch1.45 KBjibran
#4 menu-2324825-4.patch3.88 KBdawehner
#3 Add menu link Site Install.png68.93 KBberdir
#1 menu-link-defaults-2324825-1.patch2.43 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new menu-link-defaults-2324825-1.patch2.43 KB

Here is a patch. I don't think we need to set explicit defaults for things like an empty description. and title is required, so pointless to have an empty default value.

pwolanin’s picture

pwolanin commented
Issue tags: +Needs tests

oops, thanks. Should figure out why tests are not catching this

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
StatusFileSize
new Add menu link Site Install.png68.93 KB

Add form, without default values.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -Needs tests
StatusFileSize
new menu-2324825-4.patch3.88 KB

Added some proper test coverage here.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new menu-2324825-5-test-only.patch1.45 KB

Adding test only patch. To show the fails.

Status: Needs review » Needs work

The last submitted patch, 5: menu-2324825-5-test-only.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Reviewed & tested by the community

Thanks for the patch and tests @Berdir and @dawehner

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

  • webchick committed 2e992d5 on 8.0.x 
    Issue #2324825 by jibran, dawehner, Berdir: Fixed MenuLinkContent::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.