Certain browsers do not allow mixed mode content (mixing HTTP / HTTPS) and so the preview thumbnail is blocked since its hardcoded in MediaYouTubeStreamWrapper::getOriginalThumbnailPath() to return a http:// link.

So this patch changes to strip the protocol in the formatter that displays the thumbnail preview.

CommentFileSizeAuthor
#8 media_youtube-2324343-no_protocol-8.patch1.58 KBstefan.r
#2 media_youtube-2324343-no_protocol.patch1.57 KBstefan.r
thumbnail-no-protocol.patch720 bytesgrom358

Comments

pameeela’s picture

pameeela commented
Status: Active » Reviewed & tested by the community

Highly recommend this patch, because currently adding a YouTube video breaks https. With the patch, the thumb gets https as well so there are no insecure content warnings.

stefan.r’s picture

stefan.r commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new media_youtube-2324343-no_protocol.patch1.57 KB

Just wanted to reiterate RTBC status of this issue.

Attached a patch that does exactly the same thing but allows us to reuse this fix in the future.

Status: Needs review » Needs work

The last submitted patch, 2: media_youtube-2324343-no_protocol.patch, failed testing.

stefan.r’s picture

stefan.r commented
Version: 7.x-2.0-rc1 » 7.x-2.x-dev
stefan.r’s picture

stefan.r commented
Status: Needs work » Needs review

stefan.r queued 2: media_youtube-2324343-no_protocol.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 2: media_youtube-2324343-no_protocol.patch, failed testing.

stefan.r’s picture

stefan.r commented
Status: Needs work » Needs review
StatusFileSize
new media_youtube-2324343-no_protocol-8.patch1.58 KB
grom358’s picture

grom358 commented
Status: Needs review » Reviewed & tested by the community

  • aaron committed 83894fd on 7.x-2.x 
    Issue #2324343 by stefan.r, grom358: Preview thumbnail blocked when in...
aaron’s picture

aaron commented
Status: Reviewed & tested by the community » Fixed

Committed to http://drupalcode.org/project/media_youtube.git/commit/83894fd.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.