Follow-up to #2319671: ViewsDataController: Step1: Move entity views data into controllers

Problem/Motivation

In all multilingual entities are converted to use EntityViewsDataInterface

Proposed resolution

Move the rest of entities' views integrations into a views data handler.
Examples could be found in node, comment, user, taxonomy and in original #2319671: ViewsDataController: Step1: Move entity views data into controllers

Remaining tasks

file a patch

User interface changes

no

API changes

no

CommentFileSizeAuthor
#7 move_rest_of_entities_to_use_entityviewsdatainterface-2322255-7.patch15.98 KBundertext
#5 move_rest_of_entities_to_use_entityviewsdatainterface-2322255-5.patch19.27 KBundertext
#4 move_rest_of_entities_to_use_entityviewsdatainterface-2322255-4.patch19.18 KBundertext

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Novice
undertext’s picture

undertext commented
Assigned: Unassigned » undertext
undertext’s picture

undertext commented
Assigned: Unassigned » undertext
undertext’s picture

undertext commented
Status: Active » Needs review
StatusFileSize
new move_rest_of_entities_to_use_entityviewsdatainterface-2322255-4.patch19.18 KB

Hmm? Should it work with config entities? (FieldStorageConfig) Let's see.

undertext’s picture

undertext commented
StatusFileSize
new move_rest_of_entities_to_use_entityviewsdatainterface-2322255-5.patch19.27 KB

Oops. This one.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/modules/field/field.views.inc
@@ -12,33 +12,6 @@
- */
-function field_views_data() {
-  $data = array();
-  $module_handler = \Drupal::moduleHandler();
-
-  foreach (\Drupal::entityManager()->getStorage('field_storage_config')->loadMultiple() as $field) {

+++ b/core/modules/field/src/Entity/FieldStorageConfig.php
@@ -22,7 +22,8 @@
  *   id = "field_storage_config",
...
+ *     "views_data" = "Drupal\field\FieldStorageConfigViewsData"

Nope, even if this works, technically this is not the same. This is the FieldStorage entity vs. the generic views integration for fields on any kind of entities. I would like to separate this, as it is not the views integration for the field_storage_config entity itself.

undertext’s picture

undertext commented
Status: Needs work » Needs review
StatusFileSize
new move_rest_of_entities_to_use_entityviewsdatainterface-2322255-7.patch15.98 KB

Okay.

The last submitted patch, 4: move_rest_of_entities_to_use_entityviewsdatainterface-2322255-4.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you for taken this into account!

The last submitted patch, 5: move_rest_of_entities_to_use_entityviewsdatainterface-2322255-5.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6cffdfa and pushed to 8.0.x. Thanks!

  • alexpott committed 6cffdfa on 8.0.x 
    Issue #2322255 by undertext | andypost: Move the rest of core entities...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Title: Move the rest of core entities to use EntityViewsDataInterface » Move the remaining core entities to use EntityViewsDataInterface

More sane title :/ rest == REST

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.