Replace all instances of responsive_image_mapping_load(), entity_load('responsive_image_mapping') and entity_load_multiple('responsive_image_mapping') with static method calls

I've applied the patch, grepped the code, and can confirm everything looks ok.

I've applied the patch, grepped the code, and can confirm everything looks ok.

This should be postponed on #2271529: Move breakpoint settings to theme and module *.breakpoints.yml files at root level and also this should be injecting the storage into the plugin.

Tagging for Amsterdam. This is for an experienced PHP coder but novice contributor. While reviewing / checking if this patch still covers all existing calls in Core, you will learn about Drupal's dependency injection with a practical example (which is this patch). If you set this is RTBC, feel free to comment about how and why you came to the conclusion.

I'm checking it out, rerolling it because it doesn't apply anymore.

Hi there,

oenie was so nice to reroll the patch with me and show me a lot of interessting git patching workflow things by the way. :)

Thanks

We've found one occurence of entity_load(); and replaced it.

New patch attached.

Jepster, it seems it accidentally also registered the changes our Backend-Developer (service :)) made to you .gitignore file.
I've removed the lines and uploaded the (hopefully final) new patch, along with an interdiff (as requested by that same BDS :))

Looks good to me on patch review: storage is properly injected, no calls left.

...and this should actually have been 'needs review' already (re-queued patch passed), so RTBC

Looking really good... one small thing:

+++ b/core/modules/responsive_image/src/Plugin/Field/FieldFormatter/ResponsiveImageFormatter.php
@@ -23,7 +27,37 @@
+  /**
+   * {@inheritdoc}
+   */
+  public function __construct($plugin_id, $plugin_definition, FieldDefinitionInterface $field_definition, array $settings, $label, $view_mode, array $third_party_settings, EntityStorageInterface $responsive_image_mapping_storage) {

Unfortunately you can not inheritdoc here because you are adding an argument - $responsive_image_mapping_storage.

Added the missing docblock.

Added the missing docblock.

Safely ignore this double post

Thanks. Setting back with one nit pick...

+++ b/core/modules/responsive_image/src/Plugin/Field/FieldFormatter/ResponsiveImageFormatter.php
@@ -35,7 +35,24 @@ class ResponsiveImageFormatter extends ImageFormatterBase implements ContainerFa
+   *   Any third party settings settings.

Language glitch (double 'settings'). This glitch is also in the FormatterBase doc block (can be fixed there too?) so I get how that was copied...

I found two more :)

Cool.

I'm guessing that these extra one-line documentation changes do not cross the "this should be a separate patch" border...

@roderik these extra one-line documentation changes should have gone in another patch but let's not hold up this patch on that. The things is we're changing code completely out of context to the issue and risk causing rerolls in unrelated patches. However I think that the reroll risk is very small. So...

Committed fa1d2c3 and pushed to 8.0.x. Thanks!