If you go to admin/config/people/accounts and enable signatures, the 'User signatures' field is not available on the 'Manage form display' page.

CommentFileSizeAuthor
#2 2321621-2.patch2.47 KBswentel
#2 2321621-fail-2.patch1.88 KBswentel

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Configuration system, +Needs tests

Uhoh. :)

swentel’s picture

swentel commented
Status: Active » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2321621-fail-2.patch1.88 KB
new 2321621-2.patch2.47 KB

Clearing the field definition cache makes the signature field popup in manage form display. Toggling the checkbox was probably fixed somewhere else. Manage display is not there, that will happen when #1548204: Remove user signature and move it to contrib tlands, so we could simply get the patch in and then follow up there. Note, we could also re-scope that other patch to start using formatters and widgets because that's now possible on base fields.

Attached fail test + fix.

The last submitted patch, 2: 2321621-fail-2.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This test does not test what I reported in this issue. The test is verifying that the signature field is available on admin/config/people/accounts/form-display. I reported that the signature checkbox on admin/config/people/accounts doesn't work.

It looks like maybe that box on admin/comfing/people should be removed, but this patch doesn't do that either.

swentel’s picture

swentel commented
Status: Needs work » Needs review

@jhodgdon

See my comments in #2

Toggling the checkbox was probably fixed somewhere else

So checking that box now actually works (no idea where it was fixed though) ... the test also makes sure that field definitions are flushed and the field shows up in manage form display. If anything, we should probably update the issue title, because there's an actual bug here, but not anymore trying to enable or disable the checkbox.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Issue tags: +Needs issue summary update

Yeah the summary needs an update. This issue seems totally different from what I actually reported.

swentel’s picture

swentel commented
Issue summary: View changes
swentel’s picture

swentel commented
Issue tags: -Needs issue summary update

Should be fine now.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Setting back to RTBC as per #4

  • webchick committed aca1ec3 on 8.0.x 
    Issue #2321621 by swentel: Fixed Use signatures checkbox on User config...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

I manually tested and signatures do seem to be working for me, so I think jhodgdon's original bug is fixed.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.