In the example.settings.local.php file there are now two different comment types used. A couple of comments in the beginning use the // commenting and the rest of the comments use the /** */ commenting. Suggest conforming the whole file using the /** format.

CommentFileSizeAuthor
#10 y.patch411 bytessun
#1 Drupal-making_commenting_standard-2321605-1.patch1.1 KBastrocling
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

astrocling’s picture

astrocling CreditAttribution: astrocling commented
Assigned: Unassigned » astrocling
FileSize
Drupal-making_commenting_standard-2321605-1.patch1.1 KB

Standardized formatting to use the /** */ format as discussed in https://www.drupal.org/node/2321407 with jhodgdon

astrocling’s picture

astrocling CreditAttribution: astrocling commented
Assigned: astrocling » Unassigned
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Thanks, looks fine!

astrocling’s picture

astrocling CreditAttribution: astrocling commented

You are welcome, thanks for reviewing it. Is there anything else I need to do? I am only somewhat familiar with the process, don't want to miss anything.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Nothing else for you to do once the issue is marked "Reviewed and tested". Thanks!

Have you seen
https://www.drupal.org/novice
by the way? It explains the whole process pretty well...

astrocling’s picture

astrocling CreditAttribution: astrocling commented

Thanks, I hadn't seen that before. That is quite helpful.

  • alexpott committed 9399c98 on 8.0.x 
    Issue #2321605 by astrocling: Fixed Standardize Commenting in example....
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 9399c98 and pushed to 8.0.x. Thanks!

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Fixed » Needs work 
+++ b/sites/example.settings.local.php
@@ -11,18 +11,26 @@
+/**
...
+ * /
 $settings['cache']['bins']['render'] = 'cache.backend.null';

This comment is never closed; the following $settings line is commented out.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Needs review
FileSize
y.patch411 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Fixed

Thank you! Committed to 8.0.x.

  • jhodgdon committed 9c12817 on 8.0.x 
    Issue #2321605 by sun: Fix comment syntax in example.settings.local.php

Status: Fixed » Needs work

The last submitted patch, 10: y.patch, failed testing.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.