Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
Seven theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Aug 2014 at 16:57 UTC
Updated:
4 Jul 2020 at 17:56 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
lewisnymanHere's the patch. Image url paths have been updated. I'm not sure how to make this easier to review.
Comment #2
lewisnymanComment #4
sqndr commentedAdding Needs tests tag, since the tests require an update.
Comment #5
lewisnymanFixing tests and removing install CSS from every page.
Comment #6
lewisnymanJust realised I named the breadcrumb.css incorrectly
Comment #7
lewisnymanSorry, a few missing sheets.
Comment #11
lewisnymanFixing tests
Comment #12
sqndr commentedUpdated the summary.
Comment #13
sqndr commentedLooks good to me. Would love to get this in to start documenting the css.
Comment #14
webchickInteresting that our underlying system tests test stuff in Seven theme, but that's a pre-existing condition. :)
I looked through this pretty carefully and it all seems to be affecting things only in Seven theme, not in any other CSS in core, so should be safe. It's also been RTBC for about a week, which should be ample time for people to raise concerns if there are any.
Committed and pushed to 8.x. Thanks!
Comment #16
jibranSorry it added a CSS regression.
D8 now
D8 before
Comment #17
lewisnymanDid you try a reinstall? I see this on a fresh install:
Comment #18
jibranit is fine with aggregate but not without it.
Aggregate on
Aggregate off
Comment #19
lewisnymanhmm that's weird because mine was without aggregate as well.
Here's a shot from Simplytest.me
Comment #20
jibranNVM it was ABP of my chrome which doesn't allow me to load branding.css see http://stackoverflow.com/questions/23341765/getting-neterr-blocked-by-cl...
It is working fine in firefox and after disabling ABP in chrome.
Sorry for the noise and thank you for your patience @LewisNyman