The anchor selector on the crop image effect can not be changed.

Steps to reproduce:

  1. Install standard
  2. Goto admin/config/media/image-styles/manage/large
  3. And a new crop effect and change the anchor
  4. Edit the crop effect again and try to change the anchor
CommentFileSizeAuthor
#4 2319159-crop-4.patch4.05 KBmondrake
#4 2319159-crop-4-test-only.patch3.37 KBmondrake

Comments

swentel’s picture

swentel commented

Marked #2322459: Image cropping Anchor only works the first time. as a duplicate

catch’s picture

catch
he/him
Primary language English
commented

This seems more major than critical?

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: Unassigned » mondrake
Priority: Critical » Major

Working on a patch.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
StatusFileSize
new 2319159-crop-4-test-only.patch3.37 KB
new 2319159-crop-4.patch4.05 KB

We had been missing copying the content of the anchor field to the effect configuration - missing submit handler. Also, the test was failing to show that.

Test only + fix patches attached.

The last submitted patch, 4: 2319159-crop-4-test-only.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2319159-crop-4.patch, failed testing.

Status: Needs work » Needs review

mondrake queued 4: 2319159-crop-4.patch for re-testing.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Assigned: mondrake » Unassigned

Green.

mondrake queued 4: 2319159-crop-4.patch for re-testing.

mondrake’s picture

mondrake
Location 🇮🇹
commented
Issue tags: +beta target
attiks’s picture

attiks commented
Status: Needs review » Reviewed & tested by the community

marked #2334367: Anchor position doesn't get saved on cropImageEffect as duplicate

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 27b28ea and pushed to 8.0.x. Thanks!

  • alexpott committed 27b28ea on 8.0.x 
    Issue #2319159 by mondrake | alexpott: Fixed Crop anchor selector does...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.