Per issue #2034879: [Meta] Fix documentation that refers to enabling/disabling of modules, this issue is for fixing the enable/disable to install/uninstall language in the REST module

CommentFileSizeAuthor
#31 fixing_enable_to_install-2318753-31.patch8.43 KBdevin carlson
#28 fixing_enable_to_install-2318753-28.patch8.7 KBamitgoyal
#13 fixing_enable_to_install-2318753-12.patch8.33 KBgreenhodge
#11 fixing_enable_to_install-2318753-11.patch8.33 KBgreenhodge
#6 fixing_enable_to_install-2318753-5.patch3.09 KBgreenhodge
#2 fixing_enable_to_install-2318753-1.patch2.28 KBgreenhodge

Comments

greenhodge’s picture

greenhodge commented

Here we will be fixing the language in the rest_help function in rest.module from:

In order to use REST on a web site, you need to install and enable modules that provide
to
In order to use REST on a web site, you need to install modules that provide

greenhodge’s picture

greenhodge commented
StatusFileSize
new fixing_enable_to_install-2318753-1.patch2.28 KB
greenhodge’s picture

greenhodge commented
Status: Active » Needs review
les lim’s picture

les lim
he/they
Primary language English
commented
Issue summary: View changes
les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Needs work 
+++ b/core/modules/rest/rest.module
@@ -35,7 +35,7 @@
       $output .= '<dt>' . t('Enabling supporting modules') . '</dt>';

"Enabling" should be "Installing" here.

Otherwise, this looks good!

greenhodge’s picture

greenhodge commented
Status: Needs work » Needs review
StatusFileSize
new fixing_enable_to_install-2318753-5.patch3.09 KB

New patch responding to Les Lim's thing he pointed out.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks RTBC to me.

Leaving as "critical" since the parent meta is critical.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Taking another look.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Needs work

Code comments throughout Rest module tests still refer to "Modules to enable."

les lim’s picture

les lim
he/they
Primary language English
commented
Title: Fix text in REST module that refers to enabling a module » Fix documentation text in REST module that refers to enabling a module
greenhodge’s picture

greenhodge commented
StatusFileSize
new fixing_enable_to_install-2318753-11.patch8.33 KB

We believe we may have finally fixed them ALL.

greenhodge’s picture

greenhodge commented
Status: Needs work » Needs review
greenhodge’s picture

greenhodge commented
StatusFileSize
new fixing_enable_to_install-2318753-12.patch8.33 KB

Attempting to fix the end-of-line unhappiness

les lim’s picture

les lim
he/they
Primary language English
commented 
+++ b/core/modules/rest/src/Plugin/Derivative/EntityDerivative.php
@@ -122,7 +122,7 @@
+                // of module installing/uninstalling, so we simply exclude this entity

Inline code comments should still wrap at 80 characters, including the spaces in the indent.

les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Needs work

The last submitted patch, 2: fixing_enable_to_install-2318753-1.patch, failed testing.

The last submitted patch, 2: fixing_enable_to_install-2318753-1.patch, failed testing.

The last submitted patch, 6: fixing_enable_to_install-2318753-5.patch, failed testing.

The last submitted patch, 6: fixing_enable_to_install-2318753-5.patch, failed testing.

The last submitted patch, 11: fixing_enable_to_install-2318753-11.patch, failed testing.

The last submitted patch, 11: fixing_enable_to_install-2318753-11.patch, failed testing.

The last submitted patch, 13: fixing_enable_to_install-2318753-12.patch, failed testing.

The last submitted patch, 13: fixing_enable_to_install-2318753-12.patch, failed testing.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +TCDrupal 2014
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs reroll

Looks like the patches don't apply to the 8.0.x branch tip, so this will need a reroll. Thanks all!

xjm’s picture

xjm
she/her
Primary language English
commented
Priority: Critical » Normal

Let's actually make the child issues normal since these are very small patches and the critical meta will still make sure completing the task blocks release.

greenhodge’s picture

greenhodge commented
Title: Fix documentation text in REST module that refers to enabling a module » REST Module: Fix documentation that refers to enabling/disabling of modules
amitgoyal’s picture

amitgoyal commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new fixing_enable_to_install-2318753-28.patch8.7 KB

Reroll of #13 along with fixes in #14.

LinL queued 28: fixing_enable_to_install-2318753-28.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 28: fixing_enable_to_install-2318753-28.patch, failed testing.

devin carlson’s picture

devin carlson commented
Status: Needs work » Needs review
StatusFileSize
new fixing_enable_to_install-2318753-31.patch8.43 KB

Reroll of #28.

I also verified that it covers all of the instances of enable/disable.

effulgentsia’s picture

effulgentsia commented
Status: Needs review » Reviewed & tested by the community

Looks good.

effulgentsia’s picture

effulgentsia commented
Component: base system » rest.module
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a unfrozen change (documentation) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed d3f5497 and pushed to 8.0.x. Thanks!

  • alexpott committed d3f5497 on 8.0.x 
    Issue #2318753 by greenhodge, amitgoyal, Devin Carlson: REST Module: Fix...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.