Within #2247049: Redesign password strength indicator so it's less fragile the password field widths were made smaller and testing of all the password strength states was missed.
The password field strength texts print on one line apart from Strong where the "Strong" drops down onto a second line.
CSS fix to make the strength text field layouts consistent.
Write a patch.
Test patch.
Post patch with screenshots.
Review patch with screenshots and feedback.
Gives the password strength text consistent layout.
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | password-field-width-testing.png | 34.53 KB | emma.maria |
| #1 | 2318679-1-password-strength.patch | 479 bytes | ByronNorris |
| #1 | 2318679-1-password-strength.png | 268.66 KB | ByronNorris |
| password_indicator.png | 29.9 KB | emma.maria |
Comments
Comment #1
ByronNorris commentedUpdated user.module.css and the password strength text no longer flows to new line (2318679-1-password-strength.patch and example PNG). Tested in Chrome 36, Firefox 30, and Safari 8 on all viewport modes (adjusting the width to verify each responsive layout displays without error). I also noticed the progress bar css triggered between (max-width: 1010px) and (min-width: 48em) shifts the progress bar to 100%. I've included another patch which fixes the original issue and the progress bar issue in the seven theme (2318679-1-password-strength-progress-bar-fix.patch and PNG).
I figured since it was in close proximity it could be included, but let me know if you'd rather I break that out into a separate issue.
Comment #2
emma.mariaHi @Bluegriff Would you be able to take the width fix part of the patch and put it in this issue #2227121: The "Default country" dropdown element overflows the installer container at certain widths. where it has already been raised and will be more relevant?
Thanks for working on this you are ace :)
Comment #3
ByronNorris commentedHi @emma.maria will do. Glad to help!
Comment #4
emma.mariaScreenshot of before and after applied patch.
In #2247049: Redesign password strength indicator so it's less fragile the password field widths were made smaller and testing of all the password strength states was missed. I couldn't find any reasoning to why this width was picked so I'm happy for this fix to be a small increase in the width.
Comment #5
emma.mariaComment #6
emma.mariaRTBC -> 2318679-1-password-strength.patch
Comment #8
emma.mariaComment #10
emma.mariaSetting this back to RTBC, the patch that we don't want commited failed.
Patch to be considered is ...
2318679-1-password-strength.patch
Comment #11
alexpottCommitted 36dd5af and pushed to 8.0.x. Thanks!