Problem/Motivation

We already have getCompleteForm(), let's use it.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 interdiff.txt2.05 KBtim.plunkett
#5 form_state-complete_form-2318099-5.patch7.5 KBtim.plunkett
#3 form_state-complete_form-2318099-3.patch7.5 KBtim.plunkett
#1 form_state-complete_form-2318099-1.patch7.38 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new form_state-complete_form-2318099-1.patch7.38 KB

Status: Needs review » Needs work

The last submitted patch, 1: form_state-complete_form-2318099-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new form_state-complete_form-2318099-3.patch7.5 KB

Whoops.

Status: Needs review » Needs work

The last submitted patch, 3: form_state-complete_form-2318099-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new form_state-complete_form-2318099-5.patch7.5 KB
new interdiff.txt2.05 KB

Accidentally removed the &

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

Thank you for the patch and for fixing the test. It's a staright forward replace so RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 8f23dc8 and pushed to 8.0.x. Thanks!

  • alexpott committed 8f23dc8 on 8.0.x 
    Issue #2318099 by tim.plunkett: Replace $form_state['complete_form']...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.