Drupal/Core/Diff/DiffFormatter hard-codes ' ', which is then escaped by twig, breaking the diff view.

nbsp

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because spaces are double-escaped in the config diff UI
Unfrozen changes Unfrozen because it only changes the diff UI to remove double-escaped space characters
Prioritized changes The main goal of this issue is usability. A diff with messy escaped characters adding noise is undesirable
CommentFileSizeAuthor
#1 2318081-1.patch662 bytesAnonymous (not verified)
nbsp.png151.88 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new 2318081-1.patch662 bytes

here's a patch.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I manually tested this and the patch removes the   from the diff.

I've updated the summary with a beta phase evaluation.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice. This is definitely an eye-sore when doing D8 demos. While it changes the visual presentation ever-so-slightly, I don't think it's worth a whole inline-template song and dance for an empty table column.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 8639092 on 8.0.x 
    Issue #2318081 by beejeebus: remove ' ' from Drupal/Core/Diff/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.