The Footer is not used as a region in the theme and only prints the feed icons in the Twig template. Therefore an empty footer div is printed unless the feed icons are active which they are not by default.
Code printing the footer in page.html.twig...
<footer id="footer" role="contentinfo" class="layout-column">
{{ feed_icons }}
</footer>
Add an if statement for the content printed within the footer so an empty div is not always printed.
Write and test patch.
Add patch to issue,
Update issue summary with actions/decisions taken and screenshots as back up.
Test patch.
Review with screenshots.
None
None
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | drupal-remove-footer-region-in-seven-2317811-13.patch | 584 bytes | emma.maria |
| #7 | Screen Shot 2014-08-08 at 13.29.39.png | 221.27 KB | emma.maria |
| #7 | Screen Shot 2014-08-08 at 13.29.58.png | 261.51 KB | emma.maria |
| #7 | Screen Shot 2014-08-08 at 13.30.16.png | 87.51 KB | emma.maria |
| #6 | drupal-remove-footer-region-in-seven-2317811-6.patch | 408 bytes | chandeepkhosa |
Comments
Comment #1
emma.mariaComment #2
lauriiiComment #3
chandeepkhosa commentedassigning to myself
Comment #4
chandeepkhosa commentedhere is my patch, enjoy!
Comment #5
chandeepkhosa commentedready for review
Comment #6
chandeepkhosa commented2nd version of patch, without whitespace, ready for review
Comment #7
emma.mariaI applied the patch and clicked around the site, none of the page layouts are broken as a result of the patch and the footer no longer prints.
The code was removed cleanly from the twig file with no errors or coding standards broken.
Some screenshots to show non broken layout...
Comment #8
emma.mariaComment #9
alexpottWhat do you mean:
Looking at
template_preprocess_pagefeed_icons is very much alive and well. If someone adds a feed to an admin page with this patch seven would not support that.Comment #10
lauriiiIs the issue instead of footer not being used that seven can spit empty footer tags?
Comment #11
lewisnymanhmm ok, is that a use case? I guess it's possible then we should support it. Let's just add an if statement
Comment #12
emma.mariaComment #13
emma.mariaSorry for the previous hard treatment of the footer. I have wrapped the footer markup in an if statement so the footer wrapper does not print empty when the feed icons are not in use.
Comment #14
emma.mariaComment #15
lewisnymanThis looks good to me. Assuming the test comes back green.
Comment #16
alexpottCommitted 960fedc and pushed to 8.0.x. Thanks!