Panopoly Admin ruins the core Menu module's pre-fill of the menu link title from whatever is in the title input. Patch incoming to restore this by adapting the JS within Panopoly Admin.

CommentFileSizeAuthor
#3 restore_automatic_menu-2317411-3.patch2.54 KBmglaman
#1 restore_automatic_menu-2317411-1.patch2.42 KBmglaman

Comments

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new restore_automatic_menu-2317411-1.patch2.42 KB

Patch!

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Needs work

I haven't tested it, but it looks good! It would be awesome to somehow do this without having to duplicate all that code from menu.js, but the way it's written, I don't think that's possible. :-/

Could you add something to the comments that specifically states that this code was copy-pasted from menu.js, so people know they aren't supposed to edit it? Thanks!

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new restore_automatic_menu-2317411-3.patch2.54 KB

Yeah, I wish there was a better way too. Here's updated patch with better description.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Sweet, thanks, it looks good!

hefox’s picture

hefox commented

This looks correct, just added similar to openatrium and went to check of panopoly had the same issue.

hefox’s picture

hefox commented
Status: Needs review » Reviewed & tested by the community
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

  • dsnopek committed 99960f3 on 7.x-1.x 
    Update Panopoly Admin for #2317411 by mglaman: Added Restore automatic...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.