Hello,

I found a broken image in admin/reports/updates page. The picture is missing, because the type changed to .svg.

Steven

CommentFileSizeAuthor
#10 missing_pictures_in-2317077-10.patch3 KBAnonymous (not verified)
#9 missing_pictures_in-2317077-9.patch3.19 KBAnonymous (not verified)
#3 2317077-2.patch1.16 KBlongwave
#1 missing-pictures_2317077.patch1.29 KBcsakiistvan
#1 broken_image_fix.png16.24 KBcsakiistvan
Screen Shot 2014-08-07 at 11.43.32.png14.67 KBcsakiistvan

Comments

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Status: Active » Needs review
StatusFileSize
new broken_image_fix.png16.24 KB
new missing-pictures_2317077.patch1.29 KB

This is the patchm its fix the problem

Status: Needs review » Needs work

The last submitted patch, 1: missing-pictures_2317077.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2317077-2.patch1.16 KB

Rerolled

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Issue tags: +Drupalaton 2014
dawehner’s picture

dawehner
Primary language German
commented

I wonder whether we should write a small test for it.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

This has been already committed in #2298039: Remove all PNG fallbacks for SVG, dunno if we still want the test.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs tests

I guess we want ...

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work

As stated above, patch has already been committed, this issue would be to add tests to ensure these images exist.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new missing_pictures_in-2317077-9.patch3.19 KB

Checking the names of the images seems sufficient to me.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new missing_pictures_in-2317077-10.patch3 KB

Removed an unneeded if/else.

mikey_p’s picture

mikey_p commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

No harm I guess - considering we did break it. Extending test coverage is allowed in the beta. Committed b83751a and pushed to 8.0.x. Thanks!

  • alexpott committed b83751a on 8.0.x 
    Issue #2317077 by csakiistvan, pjonckiere, longwave: Missing pictures in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.