There doesn't seem to be a reason for panopoly_test to depend on panopoly_pages. All of the config necessary is already in the feature.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | panopoly_test-remove-pages-dependency-2316067-13.patch | 697 bytes | dsnopek |
There doesn't seem to be a reason for panopoly_test to depend on panopoly_pages. All of the config necessary is already in the feature.
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | panopoly_test-remove-pages-dependency-2316067-13.patch | 697 bytes | dsnopek |
Comments
Comment #1
cboyden commentedPatch attached.
Comment #2
cboyden commentedAlso, several of the tests still use the Landing Page content type. Should we switch entirely to Panopoly Test Page?
Comment #3
dsnopekThe thing is, panopoly_test actually does depend on panopoly_pages for the "body" field base, which it's attaching to it's content type. So, we've got two options:
features_exclude[dependencies][panopoly_pages] = panopoly_pagesto the panopoy_test.info file, so Features won't try to add it back later (and assume that something will have created the 'body' field)At this point, I'd be willing to go with either approach. #2 is certainly the quickest to implement, and one would expect that every distribution will create a 'body' field somehow...
Hrm, well, all tests (except for those that are meant to test panopoly_pages) should be using the step "When I am viewing a landing page" which creates the "landing page" (a page manager page, not a real content type) on the backend in a way that doesn't depend on panopoly_pages. If there are tests that manually click through the form, then those should definitely get changed to that custom step!
Comment #4
mglamanWhat if we add the exclude, and add an install file to panopoly_test. Once installed we can run node_add_body_field and attach Core's body field to the content type.
That way nothing has to be featurized, unless Behat is checking any customizations done (such as translations.)
Comment #5
mglamanThis removes Panopoly Pages dependency and uses Core body field on node type insert hook!
Comment #6
dsnopekSounds like a good plan! But you still need to add the 'features_exclude' so that the dependency doesn't get added back next time someone does
drush fu -y panopoly_tests.Comment #7
mglamanRe-roll with exclude added
Comment #8
dsnopekLooks good, but I want to try it out on Travis-CI first:
https://travis-ci.org/dsnopek/panopoly/builds/34597625
Comment #9
dsnopekThe last test runs passed, but this took more twiddling in order to get it to take with regard to Features. Here is a new patch! I'll run this one on Travis before moving on as well.
Comment #10
dsnopekHrm, it helps when it has more than 0 bytes. :-)
Comment #11
dsnopekHere's the Travis-CI build:
https://travis-ci.org/dsnopek/panopoly/builds/34634713
Comment #12
dsnopekHrm. My patch appears to be failing - I think I went too far. :-) Maybe we could try keeping the field instance in Features, but just doing the features_exclude to block the dependency? That way we don't have to do the hack that @mglaman did with adding the body field manually to the type, it'll just connect to whatever 'body' field happens to be present on the site.
Comment #13
dsnopekOk, here's a super conservative attempt.
Comment #14
dsnopekAnd here is the Travis-CI build:
https://travis-ci.org/dsnopek/panopoly/builds/34636358
Comment #15
dsnopekFinally passed on Travis-CI! Commited.