To reproduce: visit admin/structure/block on a fresh 8.0.x install.
Expected: Rendered markup, not escaped tags.

Guessing this somehow relates to twig autoescape turned on in #1825952: Turn on twig autoescape by default.

Propose to just change:

<?php
    $form['place_blocks']['title'] = array(
      '#type' => 'container',
      '#children' => '<h3>' . t('Place blocks') . '</h3>',
      // ...
?>

to:

<?php
    $form['place_blocks']['title'] = array(
      '#type' => 'container',
      '#markup' => '<h3>' . t('Place blocks') . '</h3>',
      // ...
?>
CommentFileSizeAuthor
#3 after.jpg480.05 KBMKorostoff
#3 before.jpg485.29 KBMKorostoff
#1 drupal-block_admin_escaped_tags-2315607-1.patch613 bytespingers

Comments

pingers’s picture

pingers commented
Status: Active » Needs review
StatusFileSize
new drupal-block_admin_escaped_tags-2315607-1.patch613 bytes

Thanks.

linl’s picture

linl commented
Parent issue: » #2297711: Fix HTML escaping due to Twig autoescape
MKorostoff’s picture

MKorostoff commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before.jpg485.29 KB
new after.jpg480.05 KB

Confirming that the patch posted in #1 works for me. To test this, I applied the patch locally and then navigated to admin/structure/block. I then saw that the fix was applied.

Before:
Before

After:
after

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1d1ff75 and pushed to 8.0.x. Thanks!

  • alexpott committed 1d1ff75 on 8.0.x 
    Issue #2315607 by pingers: Fixed "Place blocks" h3 tags are escaped.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: +SafeMarkup