Rename FieldDefinition to BaseFieldDefinition

It seems like this should maybe be a beta deadline. What would the implications be of changing this between beta1 and beta2? (What changes would contrib code have to make, if any?)

let's see how phpStrom rename works...
PS: pushed to sandbox/yched/1736366.git/2315237-fd2bfd branch

Missed file rename in previous patch

should fix most of failures
also renamed FieldDefinitionTest.php => BaseFieldDefinitionTest.php according class rename

merge HEAD

re-roll

At TCDrupal Sprint, going to review this patch!

Was not able to fully review this, but grep did turn up a few possible missed changes.

./core/tests/Drupal/Tests/Core/Entity/EntityManagerTest.php: $id_definition = $this->getMockBuilder('Drupal\Core\Field\FieldDefinition')
./core/tests/Drupal/Tests/Core/Entity/EntityManagerTest.php: $bundle_definition = $this->getMockBuilder('Drupal\Core\Field\FieldDefinition')
./core/lib/Drupal/Core/Field/FieldItemInterface.php: * @see \Drupal\Core\Field\FieldDefinition
./core/lib/Drupal/Core/Field/FieldItemInterface.php: * @see \Drupal\Core\Field\FieldDefinition

Even after these changes, this patch will still require some additional review.

HEAD is moving, fixed #15

This all looks good to me. All instances of FieldDefinition have been changed to BaseFieldDefinition, all tests pass, and everything else seems to check out.

Should rename FieldDefinitionTestBase to BaseFieldDefinitionTestBase since this can only test BaseFieldDefinition's

Renaming the test base class is probably a good, straightforward new contributor task.

I'm going to give this a shot.

I attempted to rename FieldDefinitionTestBase to BaseFieldDefinitionTestBase according to #18. Attached is interdiff and full patch.

Another attempt to rename FieldDefinitionTestBase to BaseFieldDefinitionTestBase according to #18. Attached is interdiff and full patch.

merged HEAD, fixed comment for base test class + #21 +#24

@daggerhart to reduce the patch size with git config:

[diff]
  renames = copies

More info is here: https://www.drupal.org/documentation/git/configure

Updating issue summary at TC Drupal camp… In progress…

Updated issue summary since #25 rolled the patch with the correct git config.

Note this patch conflicts majorly with #2283977: Create a new ConfigEntity type for storing bundle-specific customizations of base fields

Committed 8fe8142 and pushed to 8.0.x. Thanks!

We've got a few CRs to update...
https://www.drupal.org/list-changes/published/drupal?keywords_descriptio...

Updated:
https://www.drupal.org/node/1806650
https://www.drupal.org/node/1888646
https://www.drupal.org/node/2031221
https://www.drupal.org/node/2111871
https://www.drupal.org/node/2186583
https://www.drupal.org/node/2236285

no other mentions found.

FieldDefinition is making a comeback in #2935932: Add a FieldDefinition class for defining bundle fields in code..